Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NUnit to v4 #117

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Update NUnit to v4 #117

merged 5 commits into from
Dec 20, 2024

Conversation

ltrzesniewski
Copy link
Member

I'm not sure how we should update the Zebus.Testing library version... Currently we have <ZebusTestingVersion>$(ZebusVersion)</ZebusTestingVersion>, which Zebus.Testing version should we release next?

  • 4.0.0: it wouldn't be nice to have a different major than the main lib, but we bumped a dependency major version
  • 3.15.0: there is no associated Zebus version yet
  • 3.15.0-pre1: just a prerelease for the moment, but only Zebus.Testing changed

Thoughts?

@ocoanet
Copy link
Member

ocoanet commented Dec 20, 2024

I think that it is not a big issue to have a Zebus.Testing version that is ahead of the main library version. The main library version will catch up the testing library version at some point.

However, it seems to me that Zebus.Testing should be split into:

  • Zebus.Testing: a public library published as a nuget package that contains public test helpers and does not rely on NUnit
  • Zebus.Testing.Internal: a private library used by Zebus test projects that would reference NUnit

Of course this split should be discussed outside of your PR.

@ocoanet
Copy link
Member

ocoanet commented Dec 20, 2024

So either 4.0.0 or 3.15.0 could work. I suppose it is acceptable to ignore semver for the testing library.

@ltrzesniewski
Copy link
Member Author

Ok, thanks, let's go for 3.15.0 then. 👍

@ltrzesniewski ltrzesniewski merged commit 99074b7 into master Dec 20, 2024
4 checks passed
@ltrzesniewski ltrzesniewski deleted the nunit-v4 branch December 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants