-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Features Section in User Guide #34
Update Features Section in User Guide #34
Conversation
- v.1, only necessary details - need more explainations and examples for novice users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great job translating our past meeting notes into an updated user guide. Take note of our changed ideas however.
docs/UserGuide.md
Outdated
| income | Non-negative integers | Only positive numbers or zero are valid for income fields. | | ||
|
||
#### What to Expect | ||
- **If Successful:** You'll see a message: "New Contact added. Their ID is `<new customer ID>`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are probably keeping their way of representing a contact and we are removing unique customer ids, this should be changed to New person added: <NAME>; Contact: <CONTACT NUMBER>; Email: <EMAIL>; Job: <JOB>; Income: <INCOME>; Tags: <TAGS>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Tag can be assigned only by the tag
command, in add new customer case, should we just go by the Tag field N/A or just not show (cuz in use case the steps should be add new customer > the agent analyze > decide the tier)
docs/UserGuide.md
Outdated
- Missing name: "Customer requires a name." | ||
- Incorrect email format: "Please give a valid email address." | ||
- Invalid income entry: "Please use a non-negative number for income." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to do this, but we need multiple conditions when parsing the add
command, which needs to be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, so we consider remove from MVP first right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i believe that we should remove this from mvp
docs/UserGuide.md
Outdated
- Invalid income entry: "Please use a non-negative number for income." | ||
|
||
**Handling Duplicates:** | ||
If a customer with the same name, email, job, and income is already saved, you'll get a message: "This customer is already saved as a contact. Their ID is `<new customer ID>`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here, probably remove the part with the customer id. "If a customer with the same name, email, job, and income is already saved, you'll get a message: "This customer is already saved as a contact." should suffice.
docs/UserGuide.md
Outdated
#### Parameters | ||
| Parameter | Expected Format | Explanation | | ||
|-----------|-----------------------------|-----------------------------------------------------| | ||
| ID | Integer (0 to the last ID) | The ID must be a valid integer within the registered range. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can clarify that the ID, is of the customer in either
- The original list or
- Any filtered list after using the
filter
command
docs/UserGuide.md
Outdated
#### Parameters | ||
| Parameter | Expected Format | Explanation | | ||
|-----------|-----------------------------|-----------------------------------------------------| | ||
| ID | Integer (0 to the last ID) | The ID must be a valid integer within the registered range. This ensures you can view details for an existing customer. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing for the ID explanation above
docs/UserGuide.md
Outdated
note <customer id> <note here> | ||
``` | ||
- **Example:** | ||
``` | ||
note 55 He is a problematic customer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest changing note
to remark
so we don't have to refactor the command.
docs/UserGuide.md
Outdated
- Message: "Note has been added to Customer `<Customer ID>`." | ||
- **If There is an Error:** | ||
- Invalid ID: "No customer with `<Customer ID>` exists. Please input a valid ID." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above, replace note
and the id
instruction.
docs/UserGuide.md
Outdated
**Handling Duplicates:** | ||
- Although customer IDs should be unique, in the rare case where duplicates are detected, the following error message will be shown: | ||
- "Sorry, it appears that multiple customers with id: `<Customer ID>` exist. Please use the delete command to remove the duplicated customer ID." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part should be cut, since we have scrapped this idea.
docs/UserGuide.md
Outdated
tag <customer id> <tier> | ||
``` | ||
- **Example:** | ||
``` | ||
tag 69 reject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, but we will have to refactor the tags now to mean credit card tiers.
#### What to Expect | ||
- **If Successful:** | ||
- The message "Terminating program…" is displayed. | ||
- The program will then exit after a short delay, effectively closing the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature will have to be added.
docs/UserGuide.md
Outdated
**How to Use It:** | ||
- **Command Format:** | ||
``` | ||
tag <INDEX> <TIER> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
standardise tag t/
docs/UserGuide.md
Outdated
| **Find a Customer by Details** | `filter /<FLAG> <FLAG FIELD>` | `filter /n TAN LESHEW` | | ||
| **Save Remarks About Customers**| `remark <INDEX> r/ <REMARK>` | `remark 55 He is a problematic customer.` | | ||
| **Add/Replace Credit Card Tier**| `tag <INDEX> t/ <TIER>` | `tag 69 reject` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be n/ and or missing r/
docs/UserGuide.md
Outdated
| **Remove Old Customer** | `del <INDEX>` | `del 69` | | ||
| **View Details of a Customer** | `view <INDEX>` | `view 69` | | ||
| **Edit Existing Customer** | `edit <INDEX> n/<NAME> p/<PHONE> e/<EMAIL> a/<ADDRESS> j/<JOBNAME> i/<INCOME> [t/<TAG>]` | `edit 69 n/TAN LESHEW p/77337733 e/[email protected] a/COM3 j/doctor i/1000000000` | | ||
| **Find a Customer by Details** | `filter /<FLAG> <FLAG FIELD>` | `filter /n TAN LESHEW` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter / -> filter /
filter /n TAN LESHEW -> filter n/ TAN LESHEW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #33