-
Notifications
You must be signed in to change notification settings - Fork 27.2k
Commit
…nction that broke after updating gradio
- Loading branch information
There are no files selected for viewing
2 comments
on commit 6095ade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is creating a problem with stable-diffusion-webui-two-shot :
opparco/stable-diffusion-webui-two-shot#54
To make a quick recap :
The function img_array_to_temp_file calls pil_to_temp_file (who indeed has the format parameter) in Automatic1111\stable-diffusion-webui\venv\Lib\site-packages\gradio\components.py
self.pil_to_temp_file(pil_image, dir, format="png")
BUT
This function pil_to_temp_file has been overwritten in Automatic1111\stable-diffusion-webui\modules\ui_tempdir.py
# override save to file function so that it also writes PNG info
gradio.components.IOComponent.pil_to_temp_file = save_pil_to_file
AND
The function save_pil_to_file that overwrites pil_to_temp_file does not have a "format" parameter hence the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that a similar issue has occurred in this link as well.
In the future, we could probably fix this sort of breakage with
so we'd never patch something that isn't there in the first place.