Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packit configuration #70

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add packit configuration #70

merged 1 commit into from
Oct 15, 2024

Conversation

nadjaheitmann
Copy link
Contributor

No description provided.

@nadjaheitmann nadjaheitmann force-pushed the add_packit branch 2 times, most recently from 697033f to ec4f3b9 Compare October 9, 2024 10:05
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file is valid YAML 👍

I don't see a GHA yet, is that by design?

Also, if you've copied this file from somewhere, might be cool to extend the commit message body with a URL and revision.

@nadjaheitmann
Copy link
Contributor Author

nadjaheitmann commented Oct 9, 2024

file is valid YAML 👍

This is the only foreman plugin that checks the yaml format in the .packit.yaml file :) Not that this is a bad thing :)

I don't see a GHA yet, is that by design?

I think that the foreman_resource_quota needs to be explicitly added to the list of projects that are allowed to execute packit jobs. This can be done only be @sbernhard I suppose.

Also, if you've copied this file from somewhere, might be cool to extend the commit message body with a URL and revision.

I did copy it but the .packit.yaml files can be found in almost every foreman plugin but I don't think that there is really a good structure to it I could refer to.

Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'rubygem-foreman_resource_quota': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got [{'rhel-8': {'additional_modules': 'foreman-devel:el8', 'additional_repos': ['https://yum.theforeman.org/releases/nightly/el8/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el8/x86_64/']}}, {'rhel-9': {'additional_repos': ['https://yum.theforeman.org/releases/nightly/el9/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el9/x86_64/']}}] (type <class 'list'>)."]}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

2 similar comments
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'rubygem-foreman_resource_quota': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got [{'rhel-8': {'additional_modules': 'foreman-devel:el8', 'additional_repos': ['https://yum.theforeman.org/releases/nightly/el8/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el8/x86_64/']}}, {'rhel-9': {'additional_repos': ['https://yum.theforeman.org/releases/nightly/el9/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el9/x86_64/']}}] (type <class 'list'>)."]}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'rubygem-foreman_resource_quota': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got [{'rhel-8': {'additional_modules': 'foreman-devel:el8', 'additional_repos': ['https://yum.theforeman.org/releases/nightly/el8/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el8/x86_64/']}}, {'rhel-9': {'additional_repos': ['https://yum.theforeman.org/releases/nightly/el9/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el9/x86_64/']}}] (type <class 'list'>)."]}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@nadjaheitmann
Copy link
Contributor Author

nadjaheitmann commented Oct 11, 2024

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'rubygem-foreman_resource_quota': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got [{'rhel-8': {'additional_modules': 'foreman-devel:el8', 'additional_repos': ['https://yum.theforeman.org/releases/nightly/el8/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el8/x86_64/']}}, {'rhel-9': {'additional_repos': ['https://yum.theforeman.org/releases/nightly/el9/x86_64/', 'https://yum.theforeman.org/plugins/nightly/el9/x86_64/']}}] (type <class 'list'>)."]}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Looks like packit does not like valid yaml 🙃 I'll check what it is complaining about....

@bastian-src
Copy link
Contributor

LGTM, thanks! 🐠

@bastian-src bastian-src merged commit 16e1877 into main Oct 15, 2024
22 checks passed
@maximiliankolb maximiliankolb deleted the add_packit branch October 15, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants