Implement optimistic resource quota utilization computation #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Comment on lines
10
to
11
| validate :verify_resource_quota_on_create, if: -> { new_record? } | ||
| validate :verify_resource_quota_on_change, if: -> { resource_quota_id_change_to_be_saved && !new_record? } |
There was a problem hiding this comment.
Suggested change
| validate :verify_resource_quota_on_create, if: -> { new_record? } | |
| validate :verify_resource_quota_on_change, if: -> { resource_quota_id_change_to_be_saved && !new_record? } | |
| validate :verify_resource_quota_on_host_create, if: -> { new_record? } | |
| validate :verify_resource_quota_on_resource_quota_change, if: -> { resource_quota_id_change_to_be_saved && !new_record? } |
There was a problem hiding this comment.
Even better: Merge the two methods into one.
|
|
||
| host_resources.each do |resource_type, resource_value| | ||
| new_utilization[resource_type] ||= 0 | ||
| new_utilization[resource_type] = yield(new_utilization[resource_type], resource_value, resource_type) |
There was a problem hiding this comment.
Try to simplify the code such that it is easier to understand.
bastian-src
force-pushed
the
feature/switch_to_stored_utilization
branch
from
2ba48da
to
a34fedc
Compare
Use resource_quota instead of resource_quota_id for form selector and parameter filter extension
bastian-src
force-pushed
the
feature/switch_to_stored_utilization
branch
from
fdf8253
to
e5798e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of re-computing the Resource Quota utilization by iterating all Resource Quota hosts and determining their resources, an optimistic tracking of the utilized resources is implemented.
When a host is created/added to a Resource Quota, its resources are determined once and added to the Resource Quota utilization. When a host is destroyed/unassigned from a Resource Quota, its utilization is freed from the host's resource capacities.