Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new hosts details page #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use new hosts details page #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/foreman_acd/concerns/app_instance_mixins.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def collect_host_report_data(app_instance)
a_host.update({
:id => foreman_host.host.id,
:build => foreman_host.host.build,
:hostUrl => host_path(foreman_host.host),
:hostUrl => helpers.current_host_details_path(foreman_host.host),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also , does this modify our dependency to foreman, as in this method can only be used in foreman >= X.Y

:isExistingHost => foreman_host.is_existing_host,
:powerStatusUrl => power_api_host_path(foreman_host.host)
})
Expand Down
Loading