Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors #17

Merged
merged 21 commits into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
webpack/js-yaml.js
13 changes: 13 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"plugins": ["@theforeman/foreman"],
"extends": [
"plugin:@theforeman/foreman/core",
"plugin:@theforeman/foreman/plugins",
],
"rules": {
// avoid https://github.com/prettier/eslint-config-prettier/issues/29
"standard/computed-property-even-spacing": 0,
//"eqeqeq": "warn",
"max-lines": ["error", {"max": 650, "skipBlankLines": true, "skipComments": true}],
},
}
3 changes: 1 addition & 2 deletions .github/workflows/javascript_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ jobs:
- run: npm install
- name: Linting
run: |
# FIXME: we need to fix the findings, first
#npm run lint
npm run lint
npm run stylelint
- name: Testing
run: npm run test
Expand Down
1 change: 1 addition & 0 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = {
collectCoverage: true,
collectCoverageFrom: [
'webpack/**/*.js',
'!webpack/js-yaml.js',
'!webpack/index.js',
'!webpack/test_setup.js',
'!webpack/**/bundle*',
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"babel-preset-env": "^1.6.0",
"babel-preset-react": "^6.24.1",
"eslint": "^6.7.2",
"eslint-plugin-react": "^7.34.1",
"jest": "^23.6.0",
"jest-prop-type-error": "^1.1.0",
"lodash": "^4.17.11",
Expand All @@ -26,8 +27,8 @@
"table-resolver": "^3.2.0"
},
"scripts": {
"lint": "tfm-lint --plugin -d *.js,webpack",
"lint-fix": "tfm-lint --plugin -d *.js,webpack --fix",
"lint": "eslint *.js webpack",
"lint-fix": "eslint --fix *.js webpack",
"stylelint": "stylelint webpack/**/*.scss",
"stylelint-fix": "stylelint webpack/**/*.scss --fix",
"test": "jest --no-cache"
Expand Down
Loading
Loading