Skip to content

Commit

Permalink
Add (S)CSS linting
Browse files Browse the repository at this point in the history
  • Loading branch information
m-bucher committed Dec 21, 2023
1 parent 7328fba commit 2fd9f2b
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 26 deletions.
1 change: 1 addition & 0 deletions .github/workflows/javascript_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
run: |
# FIXME: we need to fix the findings, first
#npm run lint
npm run stylelint
- name: Testing
run: npm run test
...
5 changes: 5 additions & 0 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"extends": [
"stylelint-config-standard",
],
}
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,15 @@
"prettier": "^1.19.1",
"react-redux-test-utils": "^0.1.1",
"sortabular": "^1.5.1",
"stylelint": "^9.3.0",
"stylelint-config-standard": "^18.0.0",
"table-resolver": "^3.2.0"
},
"scripts": {
"lint": "tfm-lint --plugin -d *.js,webpack",
"lint-fix": "tfm-lint --plugin -d *.js,webpack --fix",
"stylelint": "stylelint webpack/**/*.scss",
"stylelint-fix": "stylelint webpack/**/*.scss --fix",
"test": "jest --no-cache"
},
"repository": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,26 @@
}

.deploy_status_head {
float:left;
width:25%;
height:10%;
float: left;
width: 25%;
height: 10%;
}

.deploy_status_content {
float:left;
width:75%;
height:10%;
float: left;
width: 75%;
height: 10%;
}

.deploy_report_hosts {
float:left;
width:25%;
height:100%;
float: left;
width: 25%;
height: 100%;
}

.deploy_report_tasks {
float:left;
width:75%;
float: left;
width: 75%;
min-height: 300px;
background-color: #ecf9fe;
padding: 10px;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@import '~@theforeman/vendor/scss/variables';

.add_existing_hosts_modal {
margin-top: 0;
margin-bottom: 0;
height: 100%;
width: 80%;
max-width: none !important;
margin-top: 0;
margin-bottom: 0;
height: 100%;
width: 80%;
max-width: none !important;
}

.row {
Expand Down
20 changes: 10 additions & 10 deletions webpack/components/ParameterSelection/ParameterSelection.scss
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
@import '~@theforeman/vendor/scss/variables';

.param_selection_modal {
margin-top: 0;
margin-bottom: 0;
height: 100%;
width: 80%;
max-width: none !important;
margin-top: 0;
margin-bottom: 0;
height: 100%;
width: 80%;
max-width: none !important;
}

.complex_data_modal {
margin-top: 0;
margin-bottom: 0;
height: 80%;
width: 40%;
max-width: none !important;
margin-top: 0;
margin-bottom: 0;
height: 80%;
width: 40%;
max-width: none !important;
}

0 comments on commit 2fd9f2b

Please sign in to comment.