Merge pull request #17 from ATIX-AG/fix_linting_errors

Fix linting errors

.eslintignore

@@ -0,0 +1 @@
+webpack/js-yaml.js

.eslintrc

@@ -0,0 +1,13 @@
+{
+  "plugins": ["@theforeman/foreman"],
+  "extends": [
+    "plugin:@theforeman/foreman/core",
+    "plugin:@theforeman/foreman/plugins",
+  ],
+  "rules": {
+    // avoid https://github.com/prettier/eslint-config-prettier/issues/29
+    "standard/computed-property-even-spacing": 0,
+    //"eqeqeq": "warn",
+    "max-lines": ["error", {"max": 650, "skipBlankLines": true, "skipComments": true}],
+  },
+}

.github/workflows/javascript_tests.yml

@@ -22,8 +22,7 @@ jobs:
       - run: npm install
       - name: Linting
         run: |
-          # FIXME: we need to fix the findings, first
-          #npm run lint
+          npm run lint
           npm run stylelint
       - name: Testing
         run: npm run test

jest.config.js

@@ -12,6 +12,7 @@ module.exports = {
   collectCoverage: true,
   collectCoverageFrom: [
     'webpack/**/*.js',
+    '!webpack/js-yaml.js',
     '!webpack/index.js',
     '!webpack/test_setup.js',
     '!webpack/**/bundle*',

package.json

@@ -15,6 +15,7 @@
     "babel-preset-env": "^1.6.0",
     "babel-preset-react": "^6.24.1",
     "eslint": "^6.7.2",
+    "eslint-plugin-react": "^7.34.1",
     "jest": "^23.6.0",
     "jest-prop-type-error": "^1.1.0",
     "lodash": "^4.17.11",
@@ -26,8 +27,8 @@
     "table-resolver": "^3.2.0"
   },
   "scripts": {
-    "lint": "tfm-lint --plugin -d *.js,webpack",
-    "lint-fix": "tfm-lint --plugin -d *.js,webpack --fix",
+    "lint": "eslint *.js webpack",
+    "lint-fix": "eslint --fix *.js webpack",
     "stylelint": "stylelint webpack/**/*.scss",
     "stylelint-fix": "stylelint webpack/**/*.scss --fix",
     "test": "jest --no-cache"