This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Just extraction #818
Open
Just extraction #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use common variable for module & target caches 2. change cache directories if exporting 3. export entire built directory to destination 4. missing relative 'include_directories' fixed
e.g. simplelog wayyyy too much copypaste
there are zero references to the project directory worth trying on ci
This reverts commit afc8202.
thegecko
suggested changes
Sep 15, 2017
docs/tutorial/yotta_link.md
Outdated
| [1/3] Building C object ym/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o | ||
| FAILED: /usr/bin/cc -I/path/to/helloyotta -I/path/to/helloyotta/yotta_modules/simplelog -I/path/to/helloyotta/yotta_modules/simplelog/source -O2 -g -DNDEBUG -include "/path/to/helloyotta/build/x86-osx-native/yotta_config.h" -MMD -MT ym/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o -MF ym/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o.d -o ym/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o -c /path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c | ||
| [1/3] Building C object modules/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o | ||
| FAILED: /usr/bin/cc -I/path/to/helloyotta -I/path/to/helloyotta/yotta_modules/simplelog -I/path/to/helloyotta/yotta_modules/simplelog/source -O2 -g -DNDEBUG -include "/path/to/helloyotta/build/x86-osx-native/yotta_config.h" -MMD -MT modules/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o -MF modules/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o.d -o modules/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o -c /path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c |
There was a problem hiding this comment.
I think this should still say ym not modules
docs/tutorial/yotta_link.md
Outdated
| @@ -64,14 +64,14 @@ error: command ['ninja'] failed | |||
| Here we can see that the file that was being built when the error occurred was: | |||
|
|
|||
| ``` | |||
| [1/3] Building C object ym/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o | |||
| [1/3] Building C object modules/simplelog/source/CMakeFiles/simplelog.dir/path/to/helloyotta/yotta_modules/simplelog/source/simplelog.c.o | |||
docs/tutorial/yotta_link.md
Outdated
| object would belong to the top-level module/app being built). So from | ||
| `/ym/simplelog/...` we can tell that the failed file is in the `simplelog` |
yotta/build.py
Outdated
| parser.add_argument('-x', '--export', dest='export', | ||
| default=False, const=True, nargs='?', | ||
| help=( | ||
| 'Export mode. If flag is set, generates builds without reference to Yotta.' |
There was a problem hiding this comment.
yotta not Yotta, or perhaps remove this comment? e.g. Export mode. If flag is set, generates a buildable folder structure in the specified folder.
yotta/test_subcommand.py
Outdated
| @@ -73,15 +74,15 @@ def moduleFromDirname(build_subdir, all_modules, toplevel_module): | |||
| modtop = True | |||
| submod = False | |||
| module = toplevel_module | |||
| # <topdir> /ym/<submod>/ym/<submod2>/somedir/somedir --> submod2 | |||
| # <topdir> /modules/<submod>/modules/<submod2>/somedir/somedir --> submod2 | |||
Add changes from @sami Haapakoski
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
'-x', '--export'option to YottaSalient points:
self.relative)