Core(M): Add support for LLVM/Clang #19

JonatanAntoni · 2023-06-27T16:26:39Z

Add compiler header for clang.
Enhance CoreValidation for clang.

CMSIS/Core/Include/cmsis_clang.h

.github/workflows/corevalidation.yml

CMSIS/CoreValidation/Project/vcpkg-configuration.json

ghost

Looks fine to me

ghost · 2023-07-18T10:48:27Z

CMSIS/Core/Include/cmsis_clang.h

+{
+  uint32_t result;
+
+#if __ARM_ISA_THUMB >= 2


replace __ARM_ISA_THUMB with __ARM_ARCH_ISA_THUMB

ghost · 2023-07-18T10:51:32Z

CMSIS/Core/Include/cmsis_clang.h

+#endif
+
+#ifndef __INITIAL_SP
+#define __INITIAL_SP              __stack


where is __stack defined?
why not use __StackTop as in GCC?

This is a linker defined symbol, defined in the linker script. We can use same names as in GCC if we adopt the linker script. I kept the symbols as defined in the toolchain provided linker script template.

if we provide the linker script than I would suggest to align the symbol names.

ghost · 2023-07-18T10:51:58Z

CMSIS/Core/Include/cmsis_clang.h

+#endif
+
+#ifndef __STACK_LIMIT
+#define __STACK_LIMIT             __stack_limit


where is __stack_limit defined?
why not use __StackLimit as in GCC?

ghost · 2023-07-18T10:52:59Z

CMSIS/Core/Include/cmsis_clang.h

+
+#if defined (__ARM_FEATURE_CMSE) && (__ARM_FEATURE_CMSE == 3U)
+#ifndef __STACK_SEAL
+#define __STACK_SEAL              __stack_seal


where is _stack_seal defined?
why not use __StackSeal as in GCC

ghost · 2023-07-18T11:10:30Z

CMSIS/Core/Include/cmsis_clang.h

+}
+#endif /* __ARM_ARCH_ISA_THUMB >= 2 */
+
+#ifdef __ARM_FEATURE_LDREX


Change
#ifdef __ARM_FEATURE_LDREX
to
#if __ARM_FEATURE_LDREX >= 7

see https://developer.arm.com/documentation/101028/0012/5--Feature-test-macros

ghost · 2023-07-18T11:19:39Z

CMSIS/Core/Include/cmsis_clang.h

+}
+
+/**
+  \brief   LDRT Unprivileged (8 bit)


are the LDR*/STR* Unprivileged instructions also covered by __ARM_FEATURE_LDREX?

Good point.

LDRT is Thumb-2 instruction, so nothing to do with exclusive access ones.

CMSIS/Core/Include/cmsis_clang.h

+{
+#if ((defined (__FPU_PRESENT) && (__FPU_PRESENT == 1U)) && \
+     (defined (__FPU_USED   ) && (__FPU_USED    == 1U))     )
+  return __builtin_arm_get_fpscr();


JonatanAntoni requested a review from a user June 27, 2023 16:26

JonatanAntoni force-pushed the llvm branch 20 times, most recently from 4f8d602 to 552460e Compare June 29, 2023 09:55

ARM-software deleted a comment from github-advanced-security bot Jun 29, 2023

JonatanAntoni force-pushed the llvm branch 3 times, most recently from 83c1ce5 to 552460e Compare June 29, 2023 13:07

github-advanced-security bot found potential problems Jul 3, 2023

View reviewed changes

CMSIS/Core/Include/cmsis_clang.h Fixed Show fixed Hide fixed

CMSIS/Core/Include/cmsis_clang.h Fixed Show fixed Hide fixed

JonatanAntoni force-pushed the llvm branch 2 times, most recently from 3cb4c3c to d315ea5 Compare July 4, 2023 07:30

ghost reviewed Jul 4, 2023

View reviewed changes

.github/workflows/corevalidation.yml Outdated Show resolved Hide resolved

ghost reviewed Jul 4, 2023

View reviewed changes

CMSIS/CoreValidation/Project/vcpkg-configuration.json Outdated Show resolved Hide resolved

ghost previously approved these changes Jul 4, 2023

View reviewed changes

JonatanAntoni force-pushed the main branch from ee5ea5f to 56488cb Compare July 4, 2023 13:48

JonatanAntoni dismissed ghost ’s stale review via aba88fc July 4, 2023 15:23

JonatanAntoni force-pushed the llvm branch from d315ea5 to aba88fc Compare July 4, 2023 15:23

JonatanAntoni force-pushed the llvm branch from 7a3b669 to acdc9b3 Compare July 13, 2023 14:45

ghost self-requested a review July 18, 2023 10:45

ghost suggested changes Jul 18, 2023

View reviewed changes

JonatanAntoni added 5 commits July 19, 2023 10:28

Core(M): Add LLVM/Clang compiler header

15b731e

CoreValidation: Add filter for LLVM/Clang Cortex-A

80273ec

Update Cortex-M target layers to use default linker scripts

cd65c36

Cleanup/update Cortex-M RTE files

f55d8c8

Fix arch and thumb instructions

36bc6db

JonatanAntoni force-pushed the llvm branch from 0919e05 to 36bc6db Compare July 19, 2023 08:30

Replaced pragma GCC with clang

41fe219

github-advanced-security bot found potential problems Jul 20, 2023

View reviewed changes

Use acle and builtins where available

9947f9e

JonatanAntoni force-pushed the llvm branch from f450b69 to 9947f9e Compare July 20, 2023 11:25

JonatanAntoni merged commit 193243d into main Jul 20, 2023
3 checks passed

JonatanAntoni deleted the llvm branch July 20, 2023 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core(M): Add support for LLVM/Clang #19

Core(M): Add support for LLVM/Clang #19

JonatanAntoni commented Jun 27, 2023

ghost left a comment

ghost Jul 18, 2023

JonatanAntoni Jul 19, 2023

ghost Jul 18, 2023

JonatanAntoni Jul 18, 2023

ghost Jul 18, 2023

ghost Jul 18, 2023

ghost Jul 18, 2023

ghost Jul 18, 2023

JonatanAntoni Jul 19, 2023

ghost Jul 18, 2023

JonatanAntoni Jul 18, 2023

JonatanAntoni Jul 19, 2023 •

edited

Loading

JonatanAntoni Jul 19, 2023

Core(M): Add support for LLVM/Clang #19

Core(M): Add support for LLVM/Clang #19

Conversation

JonatanAntoni commented Jun 27, 2023

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JonatanAntoni Jul 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JonatanAntoni Jul 19, 2023 •

edited

Loading