Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Attempt to remove pinning and fixes for ruff errors. #1666

Merged
merged 7 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
strategy:
matrix:
os: [
ubuntu-20.04,
windows-2019,
ubuntu-latest,
windows-latest,
macos-14,
macos-13,
]
Expand Down
2 changes: 1 addition & 1 deletion continuous_integration/environment-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies:
- cftime
- setuptools
- shapely
- ruff==0.4.2
- ruff
- mda-xdrlib
- xradar
- pooch
Expand Down
1 change: 1 addition & 0 deletions examples/plotting/radar-cross-section.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"metadata": {},
"outputs": [],
"source": [
"import cartopy.crs as ccrs\n",
"import matplotlib.pyplot as plt\n",
"\n",
"import pyart\n",
Expand Down
2 changes: 1 addition & 1 deletion pyart/graph/radarmapdisplay_basemap.py
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def plot_ppi_map(
data = np.ma.masked_outside(data, vmin, vmax)

# create the basemap if not provided
if type(basemap) != Basemap:
if not isinstance(basemap, Basemap):
using_corners = None not in [min_lon, min_lat, max_lon, max_lat]
if using_corners:
basemap = Basemap(
Expand Down
6 changes: 3 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
numpy
scipy
netCDF4>=1.7.0
netCDF4
matplotlib
pooch
cftime
fsspec
s3fs
open_radar_data
xradar>=0.5.0
xradar
pandas
mda-xdrlib
xarray!=0.21.0
xarray
cartopy
pint
2 changes: 1 addition & 1 deletion tests/io/test_cfradial.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ def attribute_equal(class1, class2, key, allow_str_case_diff=True):
a1 = getattr(class1, key)
a2 = getattr(class2, key)

assert type(a1) == type(a2)
assert type(a1) == type(a2) # noqa

if isinstance(a1, str) and allow_str_case_diff:
assert a1.upper() == a2.upper()
Expand Down
Loading