Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Fix errors in docstrings and comments in CAPPI and MAX_CAPPI #1649

Merged
merged 4 commits into from
Sep 18, 2024
Merged

FIX: Fix errors in docstrings and comments in CAPPI and MAX_CAPPI #1649

merged 4 commits into from
Sep 18, 2024

Conversation

syedhamidali
Copy link
Contributor

@syedhamidali syedhamidali commented Sep 17, 2024 •
edited
Loading

  • Closes #xxxx
  • Tests added
  • Documentation reflects changes

zssherman
zssherman reviewed Sep 18, 2024
View reviewed changes
pyart/graph/max_cappi.py Outdated Show resolved Hide resolved
zssherman
zssherman reviewed Sep 18, 2024
View reviewed changes
pyart/graph/max_cappi.py Outdated Show resolved Hide resolved
zssherman
zssherman requested changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the default colormap to the CVD friendly colormap? Besides that, everything else looks good!

@syedhamidali
Copy link
Contributor Author

@zssherman Please go ahead!

@zssherman zssherman self-requested a review September 18, 2024 17:45
@zssherman zssherman merged commit d6a1c15 into ARM-DOE:main Sep 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zssherman zssherman zssherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syedhamidali @zssherman