-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Animated GIF PPI Blog notebook #1598
Conversation
This is the Making animated GIFs for radar PPI plots blog. This is in relation to the Summer 2024 SULI project and it covers a convective event over Lemont, IL on June 5th, 2024
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Reopening to rerun tests now that the CI is fix. |
@BrandonWeart Looks like some linting issues that need some cleaning |
@BrandonWeart Also you need to add an author and date to the metadata of ipynb file. An example is:
Yours is:
And should be changed to:
|
I'm not sure why these linting checks aren't passing. Looking at my recent overwrite of the original file, the changes that pre-commit wants to impose here are the same ones pre-commit made on my local machine. |
@BrandonWeart Hmm that i'm not sure, let me think on that unless @mgrover1 has some thoughts? |
Yeah its kinda strange. If you look at the most recent commit I made you can see the changes. |
@mgrover1 Worked with Brandon on getting the linter stuff fixed. Metadata is in the file as well, when you have a chance for a second review. |
Hoping it's good! |
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2024-06-25T15:59:31Z Within this blog post instead of within this notebook |
View / edit / reply to this conversation on ReviewNB mgrover1 commented on 2024-06-25T15:59:31Z Include blog post instead of notebook here again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very small comments - otherwise, looks great!
Hey Max I found the first instance of notebook needed to be changed to "blog post" but where is the second one? |
@BrandonWeart At the very end, I think he means changing it from example to blog post in the final summary. |
@BrandonWeart - in the summary section! |
Didnt mean to commit twice. Had an issue with my laptop for a second but it should all be done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes! Looks good to me!
This is the Making animated GIFs for radar PPI plots blog. This is in relation to the Summer 2024 SULI project and it covers a convective event over Lemont, IL on June 5th, 2024