ADD: Addition of above_toa_filter. #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filter replaces toa parameter in gridding code and allows for the user to specify their own remove above toa filter by using the gatefilter for consistency between both gridding functions.
|
@mgrover1 Question is, do we continue if gatefilter is None, remove anything above 17000.0 for gridmapper, or leave it fully up to the user. It was originally in to speed up the slower method of grid_mapper |
|
@mgrover1 Changes have been done for backwards compatibility, this should be good now for a final review. |
|
@mgrover1 When you get a chance, this is good for a final review |
mgrover1
requested changes
Jun 17, 2024
|
@mgrover1 The only reason I removed it from the map_gates_to_grid but not grid mapper is that in map_gates_to_grid I did not see the parameter being used anywhere when I search for toa so I believe it was just there. I can add it back to be safe. |
|
@mgrover1 Added it back in. |
|
the failing test is fixed in #1597 |
mgrover1
approved these changes
Jun 17, 2024
|
thanks for making those changes @zssherman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter replaces toa parameter in gridding code and allows for the user to specify their own remove above toa filter by using the gatefilter for consistency between both gridding functions.