-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: radar_freq
param in hydroclass_semisupervised
#1573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RBhupi - can you please add a test/example here?
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RBhupi - can you please convert your example to a .py
? It should look similar to other examples (ex. https://github.com/ARM-DOE/pyart/blob/main/examples/retrieve/plot_column_subset.py). This will ensure it renders correctly on the example gallery!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hydrometeor_class_x-band_example.py
rename file to:
plot_hydrometeor_class_x_band.py
Needed so it is generated correctly.
This is failing because of the missing file. I want to use this file in my example which I can take from the ARM servers.
|
@RBhupi If you want to pull the file and run that, you can do a PR adding the file to https://github.com/openradar/open-radar-data then once the file has been added to the data directory, run python make_registry.py |
@RBhupi This looks good to me now! |
radar_freq
option when frequency information is missing from the radar object.radar_freq
.