Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: optional rectangular window dims for velocity texture analysis and bug fixes to the load_kazr method #1446

Merged
merged 9 commits into from
Aug 17, 2023
Merged

ENH: optional rectangular window dims for velocity texture analysis and bug fixes to the load_kazr method #1446

merged 9 commits into from
Aug 17, 2023

Conversation

isilber
Copy link
Contributor

@isilber isilber commented Aug 14, 2023

No description provided.

mgrover1
mgrover1 requested changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @isilber can you add/modify the test(s) here?

@mgrover1 mgrover1 changed the title optional rectangular window dims for velocity texture analysis and bug fixes to the load_kazr method ENH: optional rectangular window dims for velocity texture analysis and bug fixes to the load_kazr method Aug 16, 2023
@isilber
Copy link
Contributor Author

isilber commented Aug 16, 2023

I added two tests for the texture method:

  1. Same as the other tests verifying a value of 0, but using a rectangular filter dim input.
  2. Consistency check of texture analysis using an input scalar and an equivalent tuple input applied to a noisy velocity field.

mgrover1
mgrover1 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge!

@mgrover1 mgrover1 merged commit 70c314c into ARM-DOE:main Aug 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@zssherman zssherman Awaiting requested review from zssherman zssherman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isilber @mgrover1