FIX: Add isinstance checks to improve linting (#1444)

* FIX: Add isinstance checks to improve linting

* fix other linting errors with f-strings

pyart/aux_io/sinarame_h5.py

@@ -465,9 +465,7 @@ def write_sinarame_cfradial(path):
         radar._DeflateLevel = 5
 
         # cfrad.TIME1_to_TIME2_NAME_VCP_RANGE.nc
-        cffile = "cfrad.{time1}.0000_to_{time2}.0000" "_{b1}_{est}_{ran}".format(
-            time1=time1, time2=time2, b1=bs[0], est=bs[1], ran=bs[2]
-        )
+        cffile = f"cfrad.{time1}.0000_to_{time2}.0000" f"_{bs[0]}_{bs[1]}_{bs[2]}"
 
         print(f"Writing to {path_user}{cffile}.nc")
         write_cfradial(

pyart/graph/radardisplay.py

@@ -1203,7 +1203,7 @@ def plot_labels(self, labels, locations, symbols="r+", text_color="k", ax=None):
         """
         ax = common.parse_ax(ax)
 
-        if type(symbols) is str:
+        if isinstance(symbols, str):
             symbols = [symbols] * len(labels)
         if len(labels) != len(locations):
             raise ValueError("length of labels and locations must match")

pyart/io/cfradial.py

@@ -56,7 +56,7 @@ def read_cfradial(
     exclude_fields=None,
     include_fields=None,
     delay_field_loading=False,
-    **kwargs
+    **kwargs,
 ):
     """
     Read a Cfradial 1.4 netCDF file.
@@ -921,12 +921,12 @@ def _calculate_scale_and_offset(dic, dtype, minimum=None, maximum=None):
     if maximum < minimum:
         raise ValueError(
             "Error calculating variable scaling: "
-            "maximum: {:f} is smaller than minimum: {:f}".format(maximum, minimum)
+            f"maximum: {maximum:f} is smaller than minimum: {minimum:f}"
         )
     elif maximum == minimum:
         warnings.warn(
             "While calculating variable scaling: "
-            "maximum: {:f} is equal to minimum: {:f}".format(maximum, minimum)
+            f"maximum: {maximum:f} is equal to minimum: {minimum:f}"
         )
         maximum = minimum + 1
 

tests/io/test_cfradial.py

@@ -488,7 +488,7 @@ def attribute_equal(class1, class2, key, allow_str_case_diff=True):
 
     assert type(a1) == type(a2)
 
-    if type(a1) is str and allow_str_case_diff:
+    if isinstance(a1, str) and allow_str_case_diff:
         assert a1.upper() == a2.upper()
     else:
         assert a1 == a2