Camera factory get cameras should enumerate multiple ps3 eye cameras #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or larger distances. The symptom is currently losing face tracking at distance of approx 2 meters. the additional margin of 0.1 * width and 0.1 * height is only effective for short ranges (e.g. less than 1 meters) since the face is relatively large. For distances up to 2 meters, need additional margins approx 0.2 x width and 0.2 x height since the face is smaller For distances up to 3 meters , need additional margins approx 0.3 x width and 0.3 x height. For distances up to 4 meters, need additional margins approx 0.4 x width and 0.4 x height.
Currently CameraFactory::getCameras only enumerates 1 PS3 eye camera and up to 4 OCV cameras. Should be able to enumerated multiple PS3 eye cameras
|
Please revert the changes made to the bounding box as the're also present on the other PR (#177) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle multiple instances of PS3 eye cameras