Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python to 3.10 in payu dev environment #33

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Update python to 3.10 in payu dev environment #33

merged 3 commits into from
Aug 5, 2024

Conversation

jo-basevi
Copy link
Collaborator

The payu environments are currently use Python 3.9 as that is the default (see #32) . This PR is updating the python version in the development environment to use python>=3.10. Should the python version be fixed, e.g python=3.10?

@jo-basevi
Copy link
Collaborator Author

The f90nml on coecms channel was incompatible with python 3.10, and there's actually up-to-date f90nml on conda-forge (see #30) so this should be used instead.

@jo-basevi jo-basevi marked this pull request as ready for review August 5, 2024 05:58
aidanheerdegen
aidanheerdegen requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I reckon we should be explicit. So I guess I request changes.

env-dev.yml Outdated Show resolved Hide resolved
env-dev.yml Show resolved Hide resolved
aidanheerdegen
aidanheerdegen approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jo-basevi jo-basevi merged commit 72adad4 into main Aug 5, 2024
1 check passed
@jo-basevi jo-basevi deleted the 32-update-python-dev-env branch August 5, 2024 23:02
@jo-basevi jo-basevi mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jo-basevi @aidanheerdegen