Fixes for ACCESS-ESM1.5 Config Tests
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 73.58% 73.48% -0.11%
==========================================
Files 15 15
Lines 723 724 +1
==========================================
Hits 532 532
- Misses 191 192 +1 ☔ View full report in Codecov by Sentry. |
truth-quark
reviewed
Aug 12, 2024
truth-quark
reviewed
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through testing actual ESM1.5 configs we have found some errors in the
VALID_*_STARTandVALID_RUNTIMEconstants. Also added a check for nonexistence ofcollate.exe.mpi.Pinging @blimlim since he helped out correcting these errors.