Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prerelease PR# versioning #5

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Prerelease PR# versioning #5

merged 2 commits into from
Apr 10, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Mar 23, 2024

Updated Prerelease deployment spack env style, and uses more generic undeploy-* workflow from build-cd.

Requires ACCESS-NRI/build-cd#42 before merging
References ACCESS-NRI/ACCESS-OM2#56

@CodeGat CodeGat self-assigned this Mar 23, 2024
@CodeGat CodeGat marked this pull request as draft March 23, 2024 02:07
@CodeGat CodeGat changed the title Access-om2-56-prerelease-pr-versioning Prerelease PR# versioning Mar 24, 2024
@CodeGat CodeGat marked this pull request as ready for review April 10, 2024 04:40
@aidanheerdegen
Copy link
Member

aidanheerdegen commented Apr 10, 2024 •
edited
Loading

This looks very similar to ACCESS-NRI/ACCESS-OM2#57
Is there any point in consolidating it in some shared CI code?

@CodeGat
Copy link
Contributor Author

CodeGat commented Apr 10, 2024

Yep. That is what is currently being done with the whole OM3 thing - pulling out functionality that is similar.
This is a special case, where the CI/CD infra is almost completely identical. I'm not sure I want to create a parent repo to house the OM2-specific CI that each of them call...at least not yet. If there are more variants, then yeah.

@aidanheerdegen
Copy link
Member

A fair bit of it seems model agnostic to me, but I'll defer to you about the best approach to generification

aidanheerdegen
aidanheerdegen approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ngl, I pretty much skimmed it as I assume it is fairly identical to the ACCESS-OM2 PR

@CodeGat CodeGat merged commit d4c984d into main Apr 10, 2024
@CodeGat CodeGat deleted the access-om2-56-prerelease-pr-versioning branch April 10, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeGat @aidanheerdegen