Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: resolve gh-39 #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: resolve gh-39 #40

wants to merge 1 commit into from

Conversation

jamesplease
Copy link

This is part of, but not all of, resolving gh-39


Superagent allows you to abort requests by using req.abort(). The way this usually works is...

const req = superagent
   .get()
   .whatevs()
   .end();

// later on..
req.abort()

superagent-mocker doesn't return this from its mocked end, so this adds that back in. However, req.abort doesn't seem to be working, so I'm still investigating that.

@coveralls
Copy link

coveralls commented Oct 20, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 20de1e3 on jmeas:patch-1 into e42c904 on A:master.

@jamesplease
Copy link
Author

This will require more work, but...I'm surprised this lib doesn't support this! Aborting requests is pretty important. @A, any clues as to the changes required to make this lib work with aborting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants