Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix copyloopvar, dupword lint issues #3387

Merged

Conversation

alexandear
Copy link
Contributor

The PR enables copyloopvar and dupword linters in golangci-lint config and fixes appeared lint issues.

tc := tc, which is found by copyloopvar, is not needed in Go 1.22+.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Nov 24, 2024

Coverage Status

coverage: 59.776% (+0.02%) from 59.753%
when pulling 5a6bf2a on alexandear:refactor/fix-copyloopvar-dupword
into de7923e on 99designs:master.

@alexandear alexandear force-pushed the refactor/fix-copyloopvar-dupword branch from 1c38b4e to 5a6bf2a Compare November 24, 2024 19:19
@StevenACoffman StevenACoffman merged commit 0d5b25e into 99designs:master Nov 24, 2024
16 of 17 checks passed
@StevenACoffman
Copy link
Collaborator

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants