Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor route type generation to handle duplicate route names #40

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: Refactor route type generation to handle duplicate route names #40

merged 1 commit into from
Jul 22, 2024

Conversation

7nohe
Copy link
Owner

@7nohe 7nohe commented Jul 10, 2024

close #39

@7nohe 7nohe requested a review from NaoyaMiyagawa July 10, 2024 23:50
@7nohe 7nohe self-assigned this Jul 10, 2024
NaoyaMiyagawa
NaoyaMiyagawa approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@NaoyaMiyagawa NaoyaMiyagawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!✨ This looks helpful!

@7nohe 7nohe merged commit 3ce1baf into main Jul 22, 2024
5 checks passed
@7nohe 7nohe deleted the fix/route-name-duplication branch July 22, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaoyaMiyagawa NaoyaMiyagawa NaoyaMiyagawa approved these changes

Assignees

@7nohe 7nohe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type generation for duplicate namespaces
2 participants
@7nohe @NaoyaMiyagawa