Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support namespaced models for windows #38

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: Support namespaced models for windows #38

merged 1 commit into from
Jul 11, 2024

Conversation

7nohe
Copy link
Owner

@7nohe 7nohe commented Jun 9, 2024

fix #37

@7nohe 7nohe requested a review from NaoyaMiyagawa June 9, 2024 13:02
@7nohe 7nohe self-assigned this Jun 9, 2024
@7nohe 7nohe mentioned this pull request Jun 9, 2024
Closed
NaoyaMiyagawa
NaoyaMiyagawa approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@NaoyaMiyagawa NaoyaMiyagawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing the bug :)

SKIP_ARTISAN_COMMAND=true

Just a suggestion, but what do you think of removing this flag from test.sh, so that the typegen commands actually run in each os?

I wonder if this would help us catch same kind of error next time

@7nohe
Copy link
Owner Author

7nohe commented Jul 10, 2024 •
edited
Loading

@NaoyaMiyagawa I agree with you. However, building the Laravel Sail environment on GitHub Actions for all operating systems is challenging.
I tried it before but gave up.
If you check the commit history of PR #34, you can see that there seem to be issues with running Docker on macOS.

@7nohe 7nohe merged commit 8b7281b into main Jul 11, 2024
5 checks passed
@7nohe 7nohe deleted the fix/namespaced-models-for-windows branch July 11, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaoyaMiyagawa NaoyaMiyagawa NaoyaMiyagawa approved these changes

Assignees

@7nohe 7nohe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows incompatibility due to namespaced model in model:show
2 participants
@7nohe @NaoyaMiyagawa