Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective-C support added #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cskaynar
Copy link

@cskaynar cskaynar commented Aug 8, 2017

No description provided.

@amyleecodes
Copy link
Contributor

Thanks for the PR! I appreciate the work that went into modifying Pulley to support Objective-C, however the changes do break backwards compatibility and make using Pulley less intuitive for Swift users. As a result, I'm not going to merge these changes into the primary repo.

I will leave the PR open (unless you choose to close it), so that anyone wanting to support Objective-C can find your branch.

@CareerFairPlus
Copy link

@Brendan09 I'm in the same situation as @cskaynar and would like to use this library in my ObjC project, but I also need access to that delegate. Do you have any guidelines about ways that I could add that support without breaking backwards compatibility?

@amyleecodes
Copy link
Contributor

@CareerFairPlus Pulley uses an array of enums. Unfortunately, this is a Swift only feature. In order to remove it, this would have to be replaced with something that removes the type-safety this provides for Swift users.

My recommendation would be to write the view controllers that need to be Pulley delegates in Swift.

@CareerFairPlus
Copy link

Thanks for the quick reply. I'll consider that, as I think I can encapsulate the delegate behavior without needing to move over any existing parts of our app to Swift.

@amyleecodes
Copy link
Contributor

@CareerFairPlus Yeah, you should be able to do a view controller class in Swift that implements the delegate stuff, and then subclass that to do your view controller in Objective-C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants