Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the top of the instance/object properties panel. #7197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bouh
Copy link
Collaborator

@Bouh Bouh commented Nov 26, 2024

Make the top of the panel consistent accross instance and object, the text of the object is still selectable, and its easier to read the type is that an instance or which kind of object.

This PR

improved

Currently

before

@Bouh Bouh requested a review from 4ian as a code owner November 26, 2024 17:36
@LuniMoon
Copy link
Collaborator

Note: the "object name input" visible in the panel when an object is selected appears currently "unabled" because it didn't make it for implementation. However, it was designed to allow users to change the name of an object without having to go over the object list panel to do so.
I agree that if it doesn't get used it can be removed. However, we could consider its original purpose and evaluate if we want to enable it in a new fix before it gets completely removed.

@Bouh Bouh changed the title Improve the top of the instance/object panel. Improve the top of the instance/object properties panel. Nov 27, 2024
@Bouh
Copy link
Collaborator Author

Bouh commented Dec 10, 2024

The PR I'm proposing is practical and cosmetic, that add consistency between two parts of the UI that I've found to be more confusing than practical.

Thanks for the information, but if this field was designed to be editable, it was simply designed, never implemented. So the implementation is either thought, or not done to the end. In either case, this would require bigger technical changes, and that's not what this PR is about.

I'd like to move forward on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants