Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation tags for events #2160

Merged
merged 8 commits into from
Dec 30, 2020
Merged

Conversation

Bouh
Copy link
Collaborator

@Bouh Bouh commented Dec 30, 2020

#969 (comment)

A review is needed for the white space added with \u00A0 in JSCodeEvent.js
It's working fine, just maybe there is something prettier :)

Bouh added 6 commits December 30, 2020 18:01
- Font size look like font size of the JS code from monaco editor.
- Add translation tags.
-Use \u00A0 as a white space for keep the white space like  before.
- Keep simple special chars
@Bouh Bouh requested a review from 4ian as a code owner December 30, 2020 17:52
@Bouh Bouh self-assigned this Dec 30, 2020
@Bouh Bouh added the 👀 Needs review PR needs to be reviewed by someone. label Dec 30, 2020
Copy link
Owner

@4ian 4ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run Prettier, then should be good to go!

@Bouh Bouh merged commit dbf2086 into 4ian:master Dec 30, 2020
@Bouh Bouh deleted the Translate_events branch December 31, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Needs review PR needs to be reviewed by someone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants