Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script for restriction of map extent #83

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

wojtek19022
Copy link

This problem is resolving this issue: 3liz/lizmap-web-client#786

@rldhont
Copy link
Contributor

rldhont commented Oct 17, 2024

Thanks for your contribution.

Can you give us the Lizmap Web Client versions compatibility ?

@wojtek19022
Copy link
Author

Thanks for your contribution.

Can you give us the Lizmap Web Client versions compatibility ?

Works on LizMap 3.7+ :)

@Gustry
Copy link
Member

Gustry commented Oct 17, 2024

Thanks for your contribution @wojtek19022

@wojtek19022 Each JS file must be included in a sub-folder.

So you should rename your file from library/ui/restrict-extent.js to library/ui/restrict_extent/restrict-extent_3.7.js
It would be nice to have a README.md in this subfolder, and also a link from the main root README.md to this subfolder.

@wojtek19022
Copy link
Author

wojtek19022 commented Oct 17, 2024

Thanks for your contribution @wojtek19022

@wojtek19022 Each JS file must be included in a sub-folder.

So you should rename your file from library/ui/restrict-extent.js to library/ui/restrict_extent/restrict-extent_3.7.js It would be nice to have a README.md in this subfolder, and also a link from the main root README.md to this subfolder.

Sure, I'll do it in a next commit. @Gustry I'll also make some tests on working with for example lizmap 3.6 and 3.8

@wojtek19022
Copy link
Author

@Gustry I conducted tests on both LizMap 3.6.13 and 3.7.9. It was working really well. It also worked on 3.8.2 but in my opinion there was something wrong with calculation of extent because it went above the extent in a certaint buffer

@@ -0,0 +1,3 @@
## Resctrict area

Script limits an area for a user to go around a map. For example if you have data only in a certain country, you can limit an area of a map to a certain predefined in QGIS extent like at the video below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about which video you are referring too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah my bad. That was a copy from some other README. I'll change it right away

@wojtek19022
Copy link
Author

@Gustry I also changed supported version of lizmap because it worked also on older LizMap and in some way in 3.8

@Gustry
Copy link
Member

Gustry commented Nov 12, 2024

@Gustry I also changed supported version of lizmap because it worked also on older LizMap and in some way in 3.8

You need to rename it to library/ui/restrict-extent/restrict-extent_3.8.js according to the latest bullet point on the contributing guide https://github.com/3liz/lizmap-javascript-scripts/blob/master/CONTRIBUTING.md

@wojtek19022
Copy link
Author

Oh sorry. I'll remember it for future commits. In that case i'm gonna rename it as you said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants