Battery level support #735

JCKodel · 2022-12-07T19:32:35Z

This pull request will add 2 things:

Update the battery level on the tray itself, so it is visible without having to click on the menu (it will show all battery enabled devices, but I just have one to test, so, don't know how this would be when multiple devices shows their levels):

A new color option called Battery Level that will set the device lights from green to red, depending on the battery level

…nto cross-compilation

…ron.

…zer-macos into universal-app-support

…kage.

Universal app support (new proposal)

I think I doing these pull request correctly, but if not, I added the dmg as a release on my fork.

Shorter URL

…port Huntsman V2 Analog Support

Support for the New DeathAdder Essential

* Huntsman V2 Support * Update librazermacos * Update Readme Confirmed working in [1kc#482](1kc#482)

Huntsman V2 Support

Add Huntsman Mini to the confirmed working list

Bumps [electron](https://github.com/electron/electron) from 11.2.2 to 11.5.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v11.2.2...v11.5.0) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>

Implement Thunderbolt 4 Dock Chroma support

feat: add UI support for Razer Basilisk V3

Fixes: - Error in razermouse_driver.c - Missing additions to .gitignore from 1kc#463

- Added missing matrix brightness support - Removed `battery` from `featuresMissing` as it is unnecessary

This reverts commit fe7f2f2.

electron-builder: - Updated to the latest release - No longer a pre-release - Now uses the same electron universal version as this PR (v1.2.1) source-map-support - Updated to dedupe

…operty Add missing max DPI property to Mamba TE

Fix Basilisk V3 and Huntsman V2 Analog

Update broken support link and match text to link content

…-12.3+ Fix Complier for macOS 12.3+

…pod-master

dhobi

BatteryAnimation proposal in comments...
(The PR looks really messy because of the force push to remove the sensitive data. I recommend to create a new one and change the password...JUST in case... 👍 )

dhobi · 2022-12-07T20:18:03Z

src/main/application.js

@@ -305,6 +309,28 @@ export class Application {
    this.refreshTray(true);
  }

+  updateTrayBattery() {
+    if (this.razerApplication.deviceManager.activeRazerDevices != null) {
+      this.razerApplication.deviceManager.activeRazerDevices.forEach(device => {


The last battery device will win the "tray competition"?
If so, I would filter the activeRazerDevices for device !== null && device.hasFeature(FeatureIdentifier.BATTERY) first before trying to compute the tray title.

Reason: Written like this, it will refresh every active device even though it might not even have a batteryLevel

dhobi · 2022-12-07T20:25:29Z

src/main/menu/menubuilderdevice.js

+  return {
+    label: 'Battery level',
+    click() {
+      device.batteryLevelInterval = setInterval(() => {


What about creating this as a BatteryAnimation and add a stopAnimations() to class RazerDevice as well? You could call this.stopAnimations() inside of /*protected*/ setModeState(mode, modeArguments = null) and stop the BatteryAnimation there.
Don't forget a call to super.stopAnimations() in all classes which extend from RazerDevice and have the method stopAnimations() already.

dhobi · 2022-12-07T20:26:06Z

src/main/menu/menubuilderdevice.js

 function getFeatureBreath(application, device, feature) {
  return {
    label: 'Breathe',
    click() {
+      if(device.batteryLevelInterval) clearInterval(device.batteryLevelInterval);


All these lines are then not necessary if you go the BatteryAnimation way...

overcurrent and others added 30 commits September 12, 2021 22:45

Fix cross-compilation and enable universal app support.

4ee95d5

Add build script to streamline notarization process.

43f07a5

Update README file to reflect new release.sh build script.

ec7b849

Merge branch 'master' of https://github.com/overcurrent/razer-macos i…

191d84c

…nto cross-compilation

Add custom iohook repo that provides x64 and arm64 prebuild for elect…

01c50fe

…ron.

Add iohook as submodule properly to this branch.

2dfe258

Fine-tuning README

0f98de2

Merge branch 'cross-compilation' of https://github.com/overcurrent/ra…

8ab9c1c

…zer-macos into universal-app-support

Fix iohook compilation under universal bundle.

506e29f

Clarification to README.md regarding ad-hoc signing and universal pac…

4228988

…kage.

Merge pull request 1kc#456 from overcurrent/universal-app-support

43dabc9

Universal app support (new proposal)

Huntsman V2 Analog Support

35ee1ad

I think I doing these pull request correctly, but if not, I added the dmg as a release on my fork.

Updated README.md

a6fbca3

Update README.md

ff12d29

Update huntsman_v2_analog.json

6ddc72b

Shorter URL

Support for the New DeathAdder Essential

2fdb7d2

Merge pull request 1kc#458 from WrathofthePast/Huntsman-V2-Analog-Sup…

44ff3e0

…port Huntsman V2 Analog Support

Merge pull request 1kc#484 from WrathofthePast/master

f58e3fc

Support for the New DeathAdder Essential

Huntsman v2 support (1kc#3)

872dfcb

* Huntsman V2 Support * Update librazermacos * Update Readme Confirmed working in [1kc#482](1kc#482)

Update huntsman_v2.json

2d8ccbd

Update librazermacos

937678e

Merge pull request 1kc#486 from WrathofthePast/master

e8e8c2f

Huntsman V2 Support

Merge branch 'master' into patch-1

de4d6d5

Merge pull request 1kc#475 from rudrankriyam/patch-1

3af07d1

Add Huntsman Mini to the confirmed working list

v0.4.6 built for monterey

ccc27ae

Merge branch 'master' of github.com:1kc/razer-macos

f807fe9

Added missing features for Razer Deathadder Chroma

34bad75

Implement Thunderbolt 4 Dock Chroma support

5eebae5

Merge pull request 1kc#496 from Doridian/master

3b2bc00

Implement Thunderbolt 4 Dock Chroma support

1kc and others added 28 commits March 14, 2022 00:39

updated librazermacos

22f2baa

Huntsman v2 TKL by PrivateiFox

27d3ae0

Orochi V2 Support by WrathofthePast

57dd09a

Merge pull request 1kc#587 from fgreinacher/feat/basilisk-3

3bca699

feat: add UI support for Razer Basilisk V3

Update broken link and match text to link content

03d08c7

Fix Complier for macOS 12.3+

d056c58

Update mamba_te_wired.json

6b1499a

Fix Huntsman V2 Analog Matrix Dimensions

5a99134

Fix Basilisk V3 Support

f6cc372

Fixes: - Error in razermouse_driver.c - Missing additions to .gitignore from 1kc#463

Additional Basilisk V3 Support Fix

e94c3ff

- Added missing matrix brightness support - Removed `battery` from `featuresMissing` as it is unnecessary

Add support for BlackWidow v3 mini hyperspeed.

e52bb6c

Update packages version for M1 machines

fe7f2f2

Revert "Update packages version for M1 machines"

fc9cefe

This reverts commit fe7f2f2.

Update dependency version for M1 machines

df610b4

Update package.json

838eedc

electron-builder: - Updated to the latest release - No longer a pre-release - Now uses the same electron universal version as this PR (v1.2.1) source-map-support - Updated to dedupe

Merge pull request 1kc#605 from WrathofthePast/Add-missing-max-DPI-pr…

f06887a

…operty Add missing max DPI property to Mamba TE

Merge pull request 1kc#606 from WrathofthePast/Bug-Fixes

caae522

Fix Basilisk V3 and Huntsman V2 Analog

Merge pull request 1kc#591 from RosemaryOrchard/patch-1

46542fc

Update broken support link and match text to link content

Merge pull request 1kc#598 from WrathofthePast/Fix-Complier-for-macOS…

2b6a8c8

…-12.3+ Fix Complier for macOS 12.3+

Merge branch 'master' of github.com:dragonpod/razer-macos into dragon…

a574561

…pod-master

Merge branch 'dragonpod-master'

e97a348

Release 0.4.10

7c00d23

Battery level support

7ca87a4

Version bump

a5c63c7

Release 0.5.0

e20e6c1

Removed sensitive info

3a716af

Removed sensitive info

1db199c

Security fix for release.sh

2efb797

JCKodel force-pushed the master branch from dc7a0b0 to 2efb797 Compare December 7, 2022 20:01

dhobi requested changes Dec 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Battery level support #735

Battery level support #735

JCKodel commented Dec 7, 2022

dhobi left a comment

dhobi Dec 7, 2022

dhobi Dec 7, 2022

dhobi Dec 7, 2022

Battery level support #735

Are you sure you want to change the base?

Battery level support #735

Conversation

JCKodel commented Dec 7, 2022

dhobi left a comment

Choose a reason for hiding this comment

dhobi Dec 7, 2022

Choose a reason for hiding this comment

dhobi Dec 7, 2022

Choose a reason for hiding this comment

dhobi Dec 7, 2022

Choose a reason for hiding this comment