4k-patch #47
Open
4k-patch #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be an issue with 4k screens. I dont really know what is causing it but i changed some functions in the script to use the old calculation method for height. I hope this fixes it, it does work on wider and normal 1080p screens but since i dont own a 4k display i cant test it.
…e original height calculation for height no matter how wide the screen is. more info in issue 1hubert#46 Also: Whole script can be simplified thanks to a new genshin update which lets you select options with the F key.
…e original height calculation for height no matter how wide the screen is. more info in issue 1hubert#46 Also: Whole script can be simplified thanks to a new genshin update which lets you select options with the F key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might fix 4k issues. works as expected on 1080p and wide screens. (i could only test on 1920p height)
Changed it so it only uses the wide screen calculations if the screen is not 16:9 (and it uses the old calculations for height no matter what)
Script can be simplified with the new genshin update where it lets us use the F key to click dialogue options.
more info in issue #46