Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove proxy_cache from the global config to prevent it from being enabled for sites that don't need caching. #7516

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Anyexyz
Copy link
Contributor

@Anyexyz Anyexyz commented Dec 21, 2024

What this PR does / why we need it?

Fix the problem in https://bbs.fit2cloud.com/t/topic/8868.

Summary of your change

Removed proxy_cache from global cache configuration.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Remove `proxy_cache ` from the global config to prevent it from being enabled for sites that don't need caching.
Copy link

f2c-ci-robot bot commented Dec 21, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Dec 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223
Copy link
Member

这个配置是给反代缓存用的,去掉会出问题

@wanghe-fit2cloud
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


This configuration is used for reverse generation caching. Removing it will cause problems.

@bh1xaq
Copy link
Contributor

bh1xaq commented Dec 21, 2024

Based on the configuration of version v1, it seems more suitable to explicitly declare proxy_cache off for sites where caching is not enabled.

@zhengkunwang223 zhengkunwang223 merged commit ed60565 into 1Panel-dev:dev Dec 23, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants