Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content from Dark Alleys and Twisted Paths #78

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

cylson
Copy link

@cylson cylson commented Dec 12, 2023

Adds new content and supporting UI features.

Content for chaos mage, druid, necromancer and occultist will be added in a future PR.

) : initialBooks;

// TODO: setting this properly, lol
setTimeout( () => (set(state => { state.enabledBooks = joinedBooks })), 1000 )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the makeshift hack to ignore hydration errors we discussed @sean-clayton .
So far I have been unable to make hydration work, this definitely needs to be solved one way or another before merging.

@@ -18,6 +18,11 @@ interface AbilityItemP {
description: Ability["description"];
feats: Ability["feats"] | PartialFeat[];
usage: Ability["usage"];
version: Ability["version"];
variant: Ability["variant"];
Copy link

@pawelniegowski pawelniegowski Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These may end up collapsed into a single property.

The original design was that "version" is the rework of a class, while "variant" is a selectable option that heavily modifies its features (in particular, sorcerer bloodlines and specialist wizard in DATP).

One benefit of keeping them separate would be displaying the variant selector somewhere more appropriate, e.g. next to the bloodline section for sorcerer.

const lead = get(pageDress, "lead");
const If = (props) => (props.source && isSourceEnabled(bookstore, props.source)) ||
(props.version && isVVEnabled(bookstore,"version", props.version)) ?
props.children : null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows conditionally displayed elements within a vault page's markdown (see e.g. the Animal Companion page for usage examples).

@pawelniegowski
Copy link

I think alphabetical sorting of the Basic Rules pages is becoming a problem with Animal Companion :) Perhaps we should split that into basic and advanced/special rules, and move summoning and monster rules to the latter section?

@sean-clayton
Copy link
Collaborator

@pawelniegowski @cylson Thanks for the PR 😃 I'll be taking a look at this over the next few days---looks good so far, though! Will try to see if I can come up with a fix for that server hydration issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants