5.6.17.0 Fixed Hold Off MIDI message handling.

110-kenichi · Aug 31, 2024 · cb0774a · cb0774a
1 parent 0107567
commit cb0774a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-MAmidiMEmo 5.6.16.0 Itoken (c)2019, 2024 / GPL-2.0
+MAmidiMEmo 5.6.17.0 Itoken (c)2019, 2024 / GPL-2.0
 
 *** What is the MAmidiMEmo? ***
 
@@ -274,6 +274,7 @@ e.g.) YM2151 has 8ch FM sounds, so you can play 8 chords on MIDI 1ch or sharing
    [![Donate](https://img.shields.io/badge/Donate-PayPal-green.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=SNQ9JE3JAQMNQ)
 
 *** Changes 
+5.6.17.0 Fixed Hold Off MIDI message handling.
 5.6.16.0 Fixed ch9-18 address calculation for OPL3 for SCCI.
 5.6.15.0 Showed the program number name on ProgramNumbers property.
          Fixed ModulationRateShift prop is not working property.

diff --git a/src/mamidimemo/Program.cs b/src/mamidimemo/Program.cs
@@ -41,7 +41,7 @@ public static class Program
         /// <summary>
         /// 
         /// </summary>
-        public const string FILE_VERSION = "5.6.15.0";
+        public const string FILE_VERSION = "5.6.17.0";
 
         public const string FILE_COPYRIGHT = @"Virtual chiptune sound MIDI module ""MAmidiMEmo"" Version {0}
 Copyright(C) 2019, 2024 Itoken.All rights reserved.";

diff --git a/src/mamidimemo/instruments/SoundManagerBase.cs b/src/mamidimemo/instruments/SoundManagerBase.cs
@@ -211,7 +211,7 @@ public virtual void ProcessControlChange(ControlChangeEvent midiEvent)
                         {
                             if (t.IsSoundOff)
                                 continue;
-                            if (t.IsKeyOff && t.NoteOnEvent.Channel == midiEvent.Channel)
+                            if (!t.IsKeyOff && t.NoteOnEvent.Channel == midiEvent.Channel)
                                 ProcessKeyOff(new NoteOffEvent(t.NoteOnEvent.NoteNumber, (SevenBitNumber)0) { Channel = t.NoteOnEvent.Channel });
                         }
                     }