Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Rapid UI component scaffolding #89

Draft
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4,835 changes: 187 additions & 4,648 deletions composer.lock

Large diffs are not rendered by default.

42,134 changes: 42,134 additions & 0 deletions mu-plugins/10up-plugin/package-lock.json

Large diffs are not rendered by default.

46,369 changes: 46,369 additions & 0 deletions package-lock.json

Large diffs are not rendered by default.

17 changes: 17 additions & 0 deletions themes/10up-theme/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,20 @@ You can activate `ct.css` on any page load by including `?debug_perf=1` in the U
Considering we do not want to load script everywhere throughout the theme, we have provided engineeers with a way to trigger the `ct.css` output by using a query param.

<sub>* for 10uppers, reach out to Daine for any questions / guidance / support in regards to `ct.css`</sub>


# UI Component Generation
The theme now includes a micro-generator framework [plop](https://plopjs.com/documentation/) to rapidly create UI components.
From the theme root `npm run new`
Follow the guided menu to generate component files in a consistent manner:

- component partial
- styleguide example(s) of the partial
- component CSS
- component JS

All files are optional so you can be as granular as you like.
Including the generated files needs to be done manually in the respective index files and/or styleguide template.

Plop uses [handlebars](https://handlebarsjs.com/) template files, if you're not a fan of the opinions set in the defaults, these can be altered in *[theme]/plop-templates*.
If you would like to extend the generator, the config files lives at *[theme]/plopfile.js*.
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/*
* Example ui component Frontend styles
*/

.example-ui-component {

/* TODO */
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@import url("example-ui-component");
2 changes: 2 additions & 0 deletions themes/10up-theme/assets/css/frontend/components/index.css
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
/* Components */

/* @import url("example-ui-component"); */
@import url("skip-to-content-link.css");
15 changes: 15 additions & 0 deletions themes/10up-theme/assets/css/styleguide/styleguide.css
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,21 @@
margin-bottom: 1em;
}

.uikit__section > .content > .sub-heading {
box-sizing: border-box;
color: var(--c-uikit-accent);
font-size: 14px;
font-weight: 400;
width: 100%;
}

.uikit__section > .content > .sub-heading::after,
.uikit__section > .content > .sub-heading::before {
content: " -";
display: inline-block;
margin: 0 0 0 0.5em;
}

@media (--bp-uikit-small) {

.uikit__section > .heading {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import FindExampleUiComponent from './find-example-ui-component';

/**
* Example ui component
*
* Add a description here
*
* @return {void}
*/
const ExampleUiComponent = () => {
if (!FindExampleUiComponent()) {
return;
}

console.log('TODO: Example ui component');
};

export default ExampleUiComponent;
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Reference to the DOM element to ensure we don't search multiple times
let $elementRef = null;

// DRY re-usable component naming e.g. to create new DOM elements with BEM naming
export const EXAMPLE_UI_COMPONENT_CLASSNAME = 'example-ui-component';

/**
* FindExampleUiComponent
*
* Used to identify or determine presence of the element in the DOM
* - e.g. DRY selectors for dynamic imports
* - e.g. DRY selectors for initialisation checks
*
* @return {HTMLElement} the DOM element we are looking for
*/
const FindExampleUiComponent = () => {
$elementRef = $elementRef ?? document.querySelector(`.example-ui-component`);

return $elementRef;
};

export default FindExampleUiComponent;
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default } from './example-ui-component';
2 changes: 1 addition & 1 deletion themes/10up-theme/assets/js/frontend/frontend.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
// import foo from './components/bar';
// import ExampleUiComponent from './components/example-ui-component';
3 changes: 2 additions & 1 deletion themes/10up-theme/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
}
],
"require": {
"php": ">=7.0"
"php": ">=7.0",
"fzaninotto/faker": "^1.9.2"
},
"autoload": {
"psr-4": {
Expand Down
65 changes: 61 additions & 4 deletions themes/10up-theme/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions themes/10up-theme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@
"lint-js": "10up-toolkit lint-js",
"lint-style": "10up-toolkit lint-style",
"test": "10up-toolkit test-unit-jest",
"clean-dist": "rm -rf ./dist"
"clean-dist": "rm -rf ./dist",
"new": "plop"
},
"engines": {
"node": ">=12.0.0"
},
"devDependencies": {
"10up-toolkit": "^2.1.0"
"10up-toolkit": "^2.1.0",
willhowat marked this conversation as resolved.
Show resolved Hide resolved
"plop": "^3.0.5"
},
"dependencies": {
"normalize.css": "^8.0.1"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php
/**
* Example ui component Partial
*
* @package TenUpTheme
*/

// Add default values for ALL args here
$arg_defaults = [
// Additional classes can be passed through for edge case management
'class_names' => '',
];
$args = wp_parse_args( $args, $arg_defaults );

// Provides a final check to render the component or not
$should_render = true;
// The partial name - corresponds to naming used in CSS - used to build out child classnames (BEM)
$partial_name = 'example-ui-component';

// Extend this (.=) later on with variant specific classes if needed
$container_class_names = $args['class_names'];

// Bail early if there are any conditions that should prevent rendering
if ( ! $should_render ) {
return;
}
?>
<div class="<?php echo esc_attr( "{$partial_name} {$container_class_names}" ); ?>">
<div class="<?php echo esc_attr( "{$partial_name}__inner" ); ?>">
Partial: Example ui component goes here
</div>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?php
/**
* Example ui component Styleguide Example - Default - Partial
*
* @package TenUpTheme
*/

// phpcs:disable WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
$faker = Faker\Factory::create();

/*
* Use this to setup a specific example of the component
* for inclusion in the styleguide
* - Don't forget to include new variants of this partial in ./examples.php
* - using the $name param (currently null) to match the filename suffix
*
* Faker is a PHP library that generates fake data for you.
* https://github.com/fzaninotto/Faker
*
* For images a better alternative is usually
* https://picsum.photos
*
* For illustrations you may want to consider
* https://doodleipsum.com/
*
*/
?>
<h3 class="sub-heading">Variation: Default</h3>
<?php
get_template_part(
'partials/example-ui-component/example-ui-component',
null,
[
'class_names' => '',
]
);
?>
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php
/**
* Example ui component Styleguide Index - Partial
*
* @package TenUpTheme
*/

/*
* Use this to include ALL the example variations you think we should demonstrate
* Don't forget to include this partial in [theme]/templates/page-styleguide.php
*/
?>
<section class="uikit__section" id="example-ui-component">
<h2 class="heading">: Example ui component</h2>
<div class="content">
<?php
get_template_part(
'partials/example-ui-component/styleguide/example',
'default'
);
?>
</div>
</section>

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@import url("{{ kebabCase name }}");
willhowat marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 8 additions & 0 deletions themes/10up-theme/plop-templates/ui-component-css.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/*
* {{ sentenceCase name }} Frontend styles
*/

.{{ kebabCase name }} {

/* TODO */
}
22 changes: 22 additions & 0 deletions themes/10up-theme/plop-templates/ui-component-js-find.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Reference to the DOM element to ensure we don't search multiple times
let $elementRef = null;

// DRY re-usable component naming e.g. to create new DOM elements with BEM naming
export const {{ constantCase name }}_CLASSNAME = '{{ kebabCase name }}';

/**
* Find{{ pascalCase name }}
*
* Used to identify or determine presence of the element in the DOM
* - e.g. DRY selectors for dynamic imports
* - e.g. DRY selectors for initialisation checks
*
* @return {HTMLElement} the DOM element we are looking for
*/
const Find{{ pascalCase name }} = () => {
$elementRef = $elementRef ?? document.querySelector(`.{{ kebabCase name }}`);

return $elementRef;
};

export default Find{{ pascalCase name }};
1 change: 1 addition & 0 deletions themes/10up-theme/plop-templates/ui-component-js-index.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default } from './{{ kebabCase name }}';
18 changes: 18 additions & 0 deletions themes/10up-theme/plop-templates/ui-component-js.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import Find{{ pascalCase name }} from './find-{{ kebabCase name }}';

/**
* {{ sentenceCase name }}
*
* Add a description here
*
* @return {void}
*/
const {{ pascalCase name }} = () => {
if (!Find{{ pascalCase name }}()) {
return;
}

console.log('TODO: {{ sentenceCase name }}');
};

export default {{ pascalCase name }};
Loading