Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/send checks create/claim shovel integrations #655

Open
wants to merge 3 commits into
base: feat/send-checks-ui-mvp
Choose a base branch
from
Open

/send checks create/claim shovel integrations #655

wants to merge 3 commits into from

Conversation

nicky-LV
Copy link
Contributor

@nicky-LV nicky-LV commented Aug 8, 2024 •
edited
Loading

TODO:

  • /send checks manage UI

@github-actions GitHub Actions
Copy link

Vercel Unique URL: https://sendapp-gepp45od1-0xsend.vercel.app
Vercel Preview URL: sendapp-feat-send-checks-manage-0xsend.vercel.app
Last Commit: 0ccb4de

0xBigBoss
0xBigBoss reviewed Aug 10, 2024
View reviewed changes
supabase/migrations/20240809182925_add_send_check_tables.sql
-- Policy for viewing claimed checks: Users can only select their own claimed checks
CREATE POLICY "Users can see their own claimed checks" ON "public"."send_check_claimed" FOR
SELECT USING (
lower(concat('0x', encode(send_check_claimed.redeemer, 'hex')))::citext in (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an OR also checking the from. Users should be able to see their claimed checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xBigBoss 0xBigBoss 0xBigBoss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicky-LV @0xBigBoss