fix: Improve compatibility of AsyncIterable helpers for polyfills (Babel/Hermes related) #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces
Symbol.asyncIterator
with a polyfill implementation, similar toSymbol.observable
. It also refactortoAsyncIterable
to return an object implementing both theAsyncIterator
andAsyncIterable
shape.This change should improve compatibility with async iterator polyfills, specifically Babel transpilations, since it won't require the
Symbol.asyncIterator
polyfill to be included manually and can deal with how async iterable code is transpiled by Babel, specifically for the Hermes engine in React Native.Set of changes
toAsyncIterable
to also implementAsyncIterator
shapeasyncIteratorSymbol
polyfill to helpersobservableSymbol
to helpers