Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduce and automatically add $(ZMK.OutOfTreeSourcePath) to -iquote arguments #78

Open
zyga opened this issue Feb 18, 2021 · 0 comments · May be fixed by #79
Open

Deduce and automatically add $(ZMK.OutOfTreeSourcePath) to -iquote arguments #78

zyga opened this issue Feb 18, 2021 · 0 comments · May be fixed by #79
Labels
enhancement New feature or request

Comments

@zyga
Copy link
Owner

zyga commented Feb 18, 2021

Some projects require adding -iquote foo to CPPFLAGS to support out-of-tree builds or to otherwise build correctly. Currently this requires code such like this:

libfoo.so: CPPFLAGS += -iquote $(ZMK.OutOfTreeSourcePath)foo

It would be nice if the more direct version also worked:

libfoo.so: CPPFLAGS += -iquote foo

The module handling compatible compilers can perform the transformation automatically when foo is a directory relative to the top of the source tree.
@zyga zyga added the enhancement New feature or request label Feb 18, 2021
zyga added a commit that referenced this issue Feb 18, 2021
@zyga
WIP: Automatically add out-of-tree source path for -iquote
cd047b2 
When a particular project requires using -iquote, supporting out-of-tree
builds is cumbersome, forcing developers to discover the existence and
purpose of $(ZMK.OutOfTreeSourcePath)

For this specific compiler option we can deduce the intent and the
missing path to the source tree.

This patch is missing documentation and tests.

Fixes: #78
Signed-off-by: Zygmunt Krynicki <[email protected]>
@zyga zyga linked a pull request Feb 18, 2021 that will close this issue
Draft
zyga added a commit that referenced this issue Feb 18, 2021
@zyga
WIP: Automatically add out-of-tree source path for -iquote
cb01ab9 
When a particular project requires using -iquote, supporting out-of-tree
builds is cumbersome, forcing developers to discover the existence and
purpose of $(ZMK.OutOfTreeSourcePath)

For this specific compiler option we can deduce the intent and the
missing path to the source tree.

This patch is missing documentation and tests.

Fixes: #78
Signed-off-by: Zygmunt Krynicki <[email protected]>
zyga added a commit that referenced this issue Feb 18, 2021
@zyga
WIP: Automatically add out-of-tree source path for -iquote
143c3f9 
When a particular project requires using -iquote, supporting out-of-tree
builds is cumbersome, forcing developers to discover the existence and
purpose of $(ZMK.OutOfTreeSourcePath)

For this specific compiler option we can deduce the intent and the
missing path to the source tree.

This patch is missing documentation and tests.

Fixes: #78
Signed-off-by: Zygmunt Krynicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Automatically add out-of-tree source path for -iquote zyga/zmk
1 participant
@zyga