Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overlapping highlighting with tighter line spacing #984

Closed
dstillman opened this issue Jul 17, 2024 · 2 comments · Fixed by #987
Closed

Avoid overlapping highlighting with tighter line spacing #984

dstillman opened this issue Jul 17, 2024 · 2 comments · Fixed by #987

Comments

@dstillman
Copy link
Member

https://forums.zotero.org/discussion/comment/468295/#Comment_468295

I assume this is an issue for PSPDFKit, but the desktop one seems arguably more correct.
@mvasilak
Copy link
Contributor

Indeed these are the selection/highlight rects provided by PSPDFKit, we can transform them if we wish, according to some simple overlap detection logic. We can ask PSPDFKit support first, just in case they have a better suggestion. @mrtcode you mention some normalizing logic in the desktop client, can you please point to the relevant code?

@mrtcode
Copy link
Member

mrtcode commented Jul 18, 2024

Sure.

https://github.com/zotero/pdf.js/blob/449f8ddf0d668323dcb49a63011d7037ba5432d7/src/core/evaluator.js#L2982-L3005

@mvasilak mvasilak mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add highlight annotation transformation for overlapping lines mvasilak/zotero-ios
3 participants
@mvasilak @dstillman @mrtcode