Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning in older browsers when trying to open attachment in a reader #548

Closed
tnajdek opened this issue Jun 24, 2024 · 1 comment
Closed

Comments

@tnajdek
Copy link
Member

tnajdek commented Jun 24, 2024

While web library supports browsers as old as FF60 and Safari 11, Reader can really only support browsers that both, pdf.js and epub.js, support. Even in legacy build pdf.js seems to depend on some relatively modern browser features and currently their target is Safari 16, though I believe Safari 15 will also work.

I've made an attempt to extend this compatibility but maintaining this is not feasible. I believe that instead we should just test for features that pdf.js requires (e.g. structuredClone API seems to be a good candidate) and display an error message in browsers that lack this feature (currently we attempt to load pdf.js, which results in an error in the console and "forever" spinner in the UI).

@tnajdek
Copy link
Member Author

tnajdek commented Jun 26, 2024

I believe we also need to hide or disable the "Export with Attachments" option in the attachments list based on the same criteria, as this feature also depends on pdf.js.

tnajdek added a commit that referenced this issue Jun 27, 2024
Hide options to open in reader and to export with annotations in browsers incompatible with pdf.js
@tnajdek tnajdek closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant