Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 2.0 #137

Closed
20 tasks done
zloirock opened this issue Nov 24, 2015 · 9 comments
Closed
20 tasks done

[WIP] 2.0 #137

zloirock opened this issue Nov 24, 2015 · 9 comments

Comments

@zloirock
Copy link
Owner

...and if the situation does not change, it can be the last big release :(

@zloirock
Copy link
Owner Author

@Arnavion can you confirm the list of required DOM collections? Current list based on this your issue and comments. I'm not an expert in W3C and WHATWG specs and currently have no time to explore it.

@zloirock
Copy link
Owner Author

@guybedford will not System.global have a conflict with SystemJS?

@zloirock
Copy link
Owner Author

Any more ideas about this release?

@guybedford
Copy link

@zloirock thanks for the ping. System.global is actually already defined by SystemJS. Am I right in thinking that https://github.com/zloirock/core-js/blob/master/modules/_export.js#L21 is non-destructive so this should work out ok?

We do need to move to System.loader instead of treating System as the loader though anyway as soon as the WhatWG spec is stable enough to switch.

@zloirock
Copy link
Owner Author

@guybedford previously available System object will not be overridden. Main here - the second your point requires additional feature detection.

@Arnavion
Copy link

Sorry, I haven't been keeping up with this space. @saschanaz or users of core-js may have something to say.

BTW note the list in my comment you linked was built from experimenting with Nightly and is not based off spec(s). For example MimeTypeArray doesn't seem to be iterable. It's a mess...

Maybe just expect everyone to use Array.from ...

@saschanaz
Copy link

I had some time to quickly explore spec documents.

Yes:

  1. MediaList, StyleSheetList, and CSSRuleList are iterable as they are ArrayClasses according to the latest CSSOM working draft and the latest editor's draft.
  2. NodeList and DOMTokenList are iterable according to the W3C DOM4 final spec.

No:

  1. DOMStringList is not iterable and is deprecated according to W3C DOM4 final spec.
  2. HTMLCollection is not iterable according to the DOM4 spec.
  3. NamedNodeMap is not iterable according to the W3C and WHATWG DOM4 docs.
  4. FileList is not iterable according to File API working draft.
  5. MimeTypeArray, PluginArray, and Plugin are not iterable according to HTML5 and HTML5.1 draft specs.
  6. TouchList is not iterable according to Touch Events Level 2 spec.

@zloirock
Copy link
Owner Author

@Arnavion @saschanaz thanks for replies.

HTMLCollection is not iterable according to the DOM4 spec.

Interesting because iterable HTMLCollection - very frequent issue (#37, #68, in other trackers and chats...). If most DOM collections not required - maybe makes no sense replace Symbol in Chromium 38-40, just patch some methods, need to test it.

Some days I will not change this list, maybe someone else clarify it.

@zloirock
Copy link
Owner Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants