Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction USDC pool migrated from BOB token #79

Merged
merged 16 commits into from
Aug 3, 2023

Conversation

akolotov
Copy link
Contributor

@akolotov akolotov commented Jul 3, 2023

The pool implementation has been deployed to 0x5e93FA8819Bc074C717a92240a1689D1B81aAFcd. It differs from the contract stored in the GitHub repository by migrationToUSDC().

Before the deployment, the new approach to maintain the denominator for the pool was tested with the help of

@akolotov akolotov requested a review from k1rill-fedoseev July 3, 2023 12:02
script/scripts/BOBPoolMigration.s.sol Outdated Show resolved Hide resolved
src/zkbob/ZkBobPool.sol Outdated Show resolved Hide resolved
src/zkbob/ZkBobPool.sol Outdated Show resolved Hide resolved
script/scripts/BOBPoolMigration.s.sol Outdated Show resolved Hide resolved
script/scripts/BOBPoolMigration.s.sol Outdated Show resolved Hide resolved
src/zkbob/ZkBobPool.sol Outdated Show resolved Hide resolved
src/zkbob/ZkBobPool.sol Outdated Show resolved Hide resolved
@akolotov akolotov changed the title BOB pool migration to USDC Introduction USDC pool migrated from BOB token Aug 2, 2023
@@ -6,7 +6,6 @@ on:

env:
FOUNDRY_PROFILE: ci
FOUNDRY_VERSION: v1.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set version to nightly here, to keep it in one place? Or maybe it's even better to put it in the CI variables?
https://docs.github.com/en/actions/learn-github-actions/variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added it to the repository variables

@akolotov akolotov merged commit 569672d into develop Aug 3, 2023
@akolotov akolotov deleted the migration/bob-to-usdc branch August 3, 2023 12:22
@akolotov akolotov restored the migration/bob-to-usdc branch September 29, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants