Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not respect "editor.formatOnSave": false #92

Closed
scheibo opened this issue Mar 26, 2023 · 3 comments
Closed

does not respect "editor.formatOnSave": false #92

scheibo opened this issue Mar 26, 2023 · 3 comments

Comments

@scheibo
Copy link
Sponsor

scheibo commented Mar 26, 2023

I am finding the format on save functionality to be quite slow when editing 10k line files on my 2019 x86 macbook (#63) and would like to turn off auto formatting on save and go back to just having a keybinding which triggers formatting, but can't seem to figure out how to do so. My settings.json includes "editor.formatOnSave": false but the Zig plugin seems to disregard this.

@Vexu
Copy link
Member

Vexu commented Mar 26, 2023

I'm not sure how editor.formatOnSave is supposed to work since we don't touch it in the extension but setting it specifically for Zig does work:

    "[zig]": {
        "editor.defaultFormatter": "ziglang.vscode-zig",
        "editor.formatOnSave": false
    },

@wenq1
Copy link

wenq1 commented Mar 26, 2023

editor.formatOnSave works

@scheibo
Copy link
Sponsor Author

scheibo commented Mar 26, 2023

I'm not sure how editor.formatOnSave is supposed to work since we don't touch it in the extension but setting it specifically for Zig does work:

    "[zig]": {
        "editor.defaultFormatter": "ziglang.vscode-zig",
        "editor.formatOnSave": false
    },

Yup, this works, thanks! "editor.formatOnSave": false at the top level did not, so perhaps I was just misunderstanding how it was meant to be used. Thanks!

@scheibo scheibo closed this as completed Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants