-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Guzzle 5 #10
Comments
i am having following error while calling StripeClientTest('My_Api_Key'); Fatal error: Class 'PHPUnit_Framework_TestCase' not found in /var/www/survival/vendor/zfr/zfr-stripe/tests/ZfrStripeTest/Client/StripeClientTest.php on line 29 please let me know what i am doing wrong |
Why are you using the test client ? You should use the Stripe Client (\ZfrStripe\Client\StripeClient) Envoyé de mon iPhone
|
as with the Stripe Client (\ZfrStripe\Client\StripeClient) i am not able the use the test credit cards and On Mon, Oct 13, 2014 at 4:38 PM, Michaël Gallego [email protected]
Regards: |
Testing an API is always hard. I think the simplest way is to simply "simulate" an API response by saving the response into an array. I'm not sure to understand your problem actually :p Envoyé de mon iPhone
|
He's using a test file in his own project, while that file shouldn't be used in first place except from zf-fr/zfr-stripe. |
Artax plox :P |
Especially when Guzzle 5 was released today :( :too_much_major_versions: |
Guzzle 4 was supposed to be "the major version for the next few years" |
Major versions happen: 🎱 🎲 |
It's understandable for Guzzle (because of PSR-7... I hope the spec won't move now :/) |
The spec isn't stable yet :-\ |
I get this as well; zfr/zfr-stripe v2.9.0 requires guzzle/guzzle >=3.6,<=3.9 -> satisfiable by guzzle/guzzle[v3.6.0, v3.7.0, v3.7.1, v3.7.2, v3.7.3, v3.7.4, v3.8.0, v3.8.1, v3.9.0]. |
hhmm this should work haha :p. I don't have any issue using ZfrStripe, can you please show me your full composer.json file ? |
I am also getting the issue that @ukaner mentioned. "require": {
"laravel/framework": "4.2.*",
"dingo/api": "0.8.*",
"lucadegasperi/oauth2-server-laravel": "3.*",
"league/flysystem": "~1.0",
"aws/aws-sdk-php": "~2.7",
"league/flysystem-aws-s3-v2": "~1.0",
"aws/aws-sdk-php-laravel": "~1.1",
"league/commonmark": "0.6.*",
"laravel/cashier": "2.0.*"
},
|
Grrr I don't understnad, it's working perfectly here. V3.9 should indeed match isn't it ? :( |
Can you try forcing guzzle to 3.9 in your composer JSON? I'm wondering if another dependency of yours does not force a guzzle version prior 3.6 (if that's the case, you should ask those maintainers to allow newer versions) |
Very odd, I have updated my composer like so:
And I now get this
|
Mehhhh... There is some black magic happening. Can you try to remove zfr-stripe from your composer.josn and instead add "zfr/zfr-stripe-module": ~3.0 ? This is exactly what I have in my application and it's working correctly. I honestly don't explain it myself. the strangest is that it does not report any conflicting libraries. Only that zfr stripe request 3.9, but cannot use 3.9 u_u |
Same error again, one of these packages must be breaking it. |
I had a look at all your direct dependencies, and none of them require Guzzle directly (except the AWS SDK but it requires Guzzle ~3.7, which should resolve). I'm going to push an update of ZfrStripe to have a simpler dependency to Guzzle (~3.6 instead of an explicit range). I did that in the past because Guzzle used to introduce BC even if minor versions, but as Guzzle 5 is out, I suspect they won't change it now. |
I've just tagged v2.12.1, which requires guzzle ~3.6 instead of >=3.6,<=3.9. Can you try again (just wait a few minutes so that Packagist correctly update everything) |
Seems to be working now 👍 |
Yeah \o/. Thanks! |
what about guzzle6? 💃 |
Still waiting for Guzzle services to be available in v6 :). Guzzle commands have been updated to v6 but Guzzle services (which ZfrStripe relies on) not yet. You can see their branch here: https://github.com/guzzle/guzzle-services/tree/guzzle6 |
Huzzah! guzzle/guzzle-services@3bdd887 |
Not tagged yet isn't it ? But definitely seeems on good tracks :D |
Oh sorry @sisve , I've didn't realized it was tagged. Indeed, this means that this package could now be upgraded to Guzzle Services 1.0.0 which rely on Guzzle 6 :). unfortuantely at the moment I really don't have any availability as it's pretty long to upgrade it. However if anyone would like to take the lead of that, I've already upgraded another package of mine that I need currently to this new version: https://github.com/zf-fr/zfr-shopify. That could serve as a reference for anyone wanting to tackle an upgrade. The only small problem is that there are still some issues like this one (guzzle/guzzle-services#129) that make me think we should wait a bit :). But if anyone has time, please go on and submit a PR :). |
No description provided.
The text was updated successfully, but these errors were encountered: