-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for send_invite #90
Comments
Hi ! Thanks a lot. If you're sending us a PR with this change, I would be very happy to merge this into the library! |
I wasn't sure of what reasoning you use for the parameters you include in your definitions. For a customized invite, for example, you'd probably want a minimum of a customerId (id) and customerEmail (to) fields and likely the subject and custom_message also. But since it can technically be done with just the id on the url to send the stock message, I left those to the additional parameters in my definition |
The rule I have adopted in that library is that you must set explicitly ONLY the parameters that are absolutely required. So, in this case, if an ID is sufficient to make the call works, then all other parameters should be set as additioalParameters as you did :). You can threfore submit this as a PR. If there are any problem I'll let you know which change needs to be done. |
that's what I figured |
I added a bare-bones definition in mine:
With nothing but the id, it sends a standard invite. Otherwise you can include additional details to customize it:
The text was updated successfully, but these errors were encountered: