Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UI components into Connection-based classes #117

Closed
zethon opened this issue Nov 13, 2023 · 1 comment · Fixed by #116
Closed

Refactor UI components into Connection-based classes #117

zethon opened this issue Nov 13, 2023 · 1 comment · Fixed by #116
Assignees
@zethon
Labels
enhancement

Comments

@zethon
Copy link
Owner

zethon commented Nov 13, 2023

No description provided.

@zethon zethon self-assigned this Nov 13, 2023
@zethon
Copy link
Owner Author

zethon commented Nov 13, 2023 •
edited
Loading

Update

The content view is now a generic QWidget that can be added to the forumTopStack which is in the MainWindow.ui file. I removed the default objects and now the board objects are added, as well as a OwlWebBrowser object, and you can scroll through these using the bottom two buttons in the BoardIconView.

The next step if to figure out how to put this in the BoardIconModel. Right now that class iterates the persisted boards using BoardManger and then manually adds a couple icons to the "bottom" of the model. There needs to be some generic way to access "Connections" through the model. Examples of these connections could be:

  • Board objects that use the ForumConnectionFrame view
  • A web browser view that uses the OwlWebBrowser view
  • (future) individual Reddit connections (i.e. one per login)

The last checkin (here) was removing the default ForumConnectionFrame that was originally added in the MainWindow.ui, and now all objects in the forumTopStack are added dynamically when loading boards (and manually such as the case of the single web browser).

zethon added a commit that referenced this issue Nov 13, 2023
@zethon
Removing the MainWindow.ui ForumConnectionView and now only populatin…
db8fe82 
…g the UI with dynamic objects;

See: #117 (comment)
@zethon zethon linked a pull request Nov 14, 2023 that will close this issue
Code cleanup; #116
Merged
@zethon zethon pinned this issue Nov 14, 2023
zethon added a commit that referenced this issue Jun 1, 2024
@zethon
Code cleanup; (#116)
7ea00f1 
* cleaning up code;

* update copyright;

* removing dead code;

* removing more dead code;

* more old code deleting;

* removing even more dead code;

* replacing connect messags;

* a proof of concept for putting a browser in a frame;

* where is webbrowser.cpp/h?

* WTF?

* messy checkin that i don't want to lose;

* Removing the MainWindow.ui ForumConnectionView and now only populating the UI with dynamic objects;
See: #117 (comment)

* clicking boards now works;

* fix creating a uuid for boards when they're added;

* other minor updated;

* this is a mess. but let's check it in;

* THIS IS A MESS I DO NOT WANT TO LOSE;

* a mess I don't want to lose;

* this kinda works but needs lots of cleanup;

* LIVING ON THE EDGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zethon zethon

Labels
enhancement
Projects
Owl 2024 Release
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code cleanup; zethon/Owl
1 participant
@zethon