Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remark-align/remark-iframes : aligned video are not parsed #293

Open
artragis opened this issue Oct 29, 2018 · 0 comments
Open

remark-align/remark-iframes : aligned video are not parsed #293

artragis opened this issue Oct 29, 2018 · 0 comments
Labels
misc/help wanted This issue needs help semver/major This is a breaking change status/verified This has been checked by a maintainer type/request This is great to have

Comments

@artragis
Copy link
Member

using this minimal markdown :

-> !(https://www.youtube.com/watch?v=BrGwJC6PiB0) <-

I get

 <div class="align-center"><p> !(<a href="https://www.youtube.com/watch?v=BrGwJC6PiB0">https://www.youtube.com/watch?v=BrGwJC6PiB0</a>) </p></div>

but we expect the same behaviour as

->
!(https://www.youtube.com/watch?v=BrGwJC6PiB0)
<-

i.e :

 <div class="align-center"><div class="video-container"><div class="video-wrapper"><iframe src="https://www.youtube.com/embed/BrGwJC6PiB0" width="560" height="315" allowfullscreen frameborder="0"></iframe></div></div></div>
@vhf vhf added the misc/help wanted This issue needs help label Nov 29, 2018
@StaloneLab StaloneLab added semver/major This is a breaking change status/verified This has been checked by a maintainer type/request This is great to have labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc/help wanted This issue needs help semver/major This is a breaking change status/verified This has been checked by a maintainer type/request This is great to have
Projects
None yet
Development

No branches or pull requests

3 participants