Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

"helm secrets clean ." does not work #159

Open
raufkk opened this issue Jun 3, 2020 · 1 comment
Open

"helm secrets clean ." does not work #159

raufkk opened this issue Jun 3, 2020 · 1 comment

Comments

@raufkk
Copy link

raufkk commented Jun 3, 2020

After decrypting and then cleaning with '.' as directory does not work.

➜  helm-secret git:(master) ✗ ls -l
total 8
drwxr-xr-x  7 abdul  staff   224 Jun  3 15:27 nginx
-rw-r--r--  1 abdul  staff  2439 Jun  3 17:41 secret.yaml
➜  helm-secret git:(master) ✗ helm secrets dec secret.yaml
Decrypting secret.yaml
➜  helm-secret git:(master) ✗
➜  helm-secret git:(master) ✗ ls -l
total 16
drwxr-xr-x  7 abdul  staff   224 Jun  3 15:27 nginx
-rw-r--r--  1 abdul  staff  2439 Jun  3 17:41 secret.yaml
-rw-r--r--  1 abdul  staff   118 Jun  3 17:57 secret.yaml.dec
➜  helm-secret git:(master) ✗
➜  helm-secret git:(master) ✗ helm secrets clean .
➜  helm-secret git:(master) ✗
➜  helm-secret git:(master) ✗ ls -l
total 16
drwxr-xr-x  7 abdul  staff   224 Jun  3 15:27 nginx
-rw-r--r--  1 abdul  staff  2439 Jun  3 17:41 secret.yaml
-rw-r--r--  1 abdul  staff   118 Jun  3 17:57 secret.yaml.dec
➜  helm-secret git:(master) ✗
@kaarolch
Copy link
Contributor

kaarolch commented Jul 8, 2020

@raufkk I found the issue. Current release approach that all secret files have to match the pattern: https://github.com/zendesk/helm-secrets/blob/master/secrets.sh#L441. Unfortunately, we do not check this constrains during decryption but when we removed files we search for file secrets*.yaml https://github.com/zendesk/helm-secrets/blob/master/secrets.sh#L441 I will correct it this week to not allow decrypt files that not match the pattern.
Also please rename your file to secrets.yaml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants