You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
There have been at least 2 other issues raised regarding the naming restrictions of helm secrets plugin on files it automatically identifies as containing secrets. Currently it is secrets.yaml and secrets.something.yaml (and something can contain dashes, underscores, letters, numbers). However I don't think it is very common for people to use dot as a separator to further qualify the purpose of a file. Most people would intuitively go for dash or underscore like secrets-myenv1.yaml or secrets_myenv1.yaml.
So I'd like to propose that the name search include not just dot, but also hyphen and underscore. I imagine there should only be a couple places in the code to fix, or are there a whole bunch? I don't mind doing it.
The text was updated successfully, but these errors were encountered:
schollii
changed the title
Support secrets-*.yaml
Support secrets[._-]*.yaml
Jul 23, 2019
There have been at least 2 other issues raised regarding the naming restrictions of helm secrets plugin on files it automatically identifies as containing secrets. Currently it is secrets.yaml and secrets.something.yaml (and something can contain dashes, underscores, letters, numbers). However I don't think it is very common for people to use dot as a separator to further qualify the purpose of a file. Most people would intuitively go for dash or underscore like secrets-myenv1.yaml or secrets_myenv1.yaml.
So I'd like to propose that the name search include not just dot, but also hyphen and underscore. I imagine there should only be a couple places in the code to fix, or are there a whole bunch? I don't mind doing it.
The text was updated successfully, but these errors were encountered: